[Feature/#7] time&seats screen 공통 컴포넌트 & seats 스크린 모달 구현 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0se0
requested changes
Nov 20, 2024
There was a problem hiding this comment.
- 전체적인 컴포넌트 파일에서 사용하지 않는 import들을 지워주세요.
- 서버에서 보내주는 값을 확인하고 인자로 넣어주세요!
ex)starttime, endtime - clickable이 설정된 것도 있고, 아닌 것도 있는데 norippleclick 확장함수를 만들어서 넣어주세요.
- 컴포넌트 사용이 제대로 되고 있는 것이 맞는지 임시 화면을 만들어서 보여주세요!
- 주석은 삭제해주세요! 모든 컴포넌트 인자에서 modifier을 전달해주는 것이 확장성에 더 좋을 거 같아요!
먼저 이 5가지를 수정해주신 후 리퀘스트 백 부탁드려용
kamja0510
reviewed
Nov 20, 2024
There was a problem hiding this comment.
와 컴포넌트화 이렇게까지 할 수 있네요?
저는 다 다른 버튼이라 다 만들 것 같았는데
There was a problem hiding this comment.
오히려 비효율적이구 헷갈리려나... 싶어서 다시 나눌까 고민중이어요 ㅎㅎㅜㅠ..
…N-ANDROID-CGV into ui/#7-seats-screen-components
tunaunnie
changed the title
0se0
reviewed
Nov 22, 2024
Comment on lines
+9
to
+20
| @Composable | ||
| fun Modifier.norippleclick( | ||
| enabled: Boolean = true, | ||
| onClick: () -> Unit | ||
| ): Modifier { | ||
| return this.clickable( | ||
| interactionSource = remember { MutableInteractionSource() }, | ||
| indication = null, | ||
| enabled = enabled, | ||
| onClick = onClick | ||
| ) | ||
| } |
There was a problem hiding this comment.
여기 norippleclick 제가 develop에 넣어 놓았으니 그거 사용해주시면 될 거 같아요!
Comment on lines
+45
to
+51
| var isClicked by remember { mutableStateOf(false) } | ||
| var isClickedCard by remember { mutableStateOf(true) } | ||
|
|
||
| val backgroundColor = if (isClicked) Gray700 else White | ||
| val backgroundColor2 = if (isClicked) Gray700 else Gray200 | ||
| val leftSeatsColor = if (isClickedCard) PrimaryRed400 else Green | ||
|
|
There was a problem hiding this comment.
onclick을 인자로 넣어주시고, 그 안에서 배경색을 조절하면 좋을 거 같아요!
Comment on lines
+74
to
+80
| val (buttonWidth, buttonHeight) = remember(length) { | ||
| when (length) { | ||
| "long" -> Pair(324.dp, 54.dp) | ||
| "half" -> Pair(156.dp, 54.dp) | ||
| else -> Pair(324.dp, 54.dp) | ||
| } | ||
| } |
There was a problem hiding this comment.
버튼 크기를 고정 dp로 주는 것이 아닌, 텍스트를 기준으로 horizontalPadding, verticalPadding을 주신후 나중에 스크린에서 전체 화면에서의 패딩을 조절하면 기기 대응에도 더 좋을 거 같습니당
Comment on lines
+92
to
+96
| ) | ||
| .norippleclick() { | ||
| /* Todo - behavior after cliking the button */ | ||
| } | ||
| ) { |
Comment on lines
+19
to
+24
| fun SeatSelectionModal1( | ||
| seatSelectionMovieTitle: String, | ||
| chipContents: List<String>, | ||
| onBackClick: () -> Unit, | ||
| onSeatSelectionClick: () -> Unit | ||
| ) { |
0se0
approved these changes
Nov 22, 2024
tunaunnie
added a commit
that referenced
this pull request
Nov 22, 2024
tunaunnie
added a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Issue
💻 Work Description
📸 Screenshot
default.mp4
공통
Seat 스크린 컴포넌트
💭 To Reviewers