Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 웹툰 검색 API 연동 #27

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

t1nm1ksun
Copy link
Collaborator

@t1nm1ksun t1nm1ksun commented Nov 25, 2024

Related issue 🛠

Work Description ✏️

  • WebtoonsService 구현
  • WebtoonsResponseDto 구현
  • DayWbtoonsResponseDto 구현
  • WebtoonsDataSource 구현
  • WebtoonsDataSourceImpl 구현
  • WebtoonsRepository 구현
  • WebtoonsRepositoryImpl 구현
  • SearchWebtoonsUsecase구현
  • DataSourceModule -> WebtoonsDataSource + WebtoonsDataSourceImpl 바인딩
  • RepositoryModule -> WebtoonsRepository + WebtoonsRepositoryImpl 바인딩
  • empty card view 추가

Screenshot 📸

2024-11-26.1.12.44.mov

Uncompleted Tasks 😅

  • 서버와 검색로직 상의

To Reviewers 📢

한글 특성상 자음,모음이 나누어져 있어 한 글자가 완성되어야 검색이 됩니다.
이는 서버와 상의해보겠습니다!

서버 리소스가 제한적이라 모든 검색결과의 이미지Url을 넣지 못한다고하여 Empty card 피그마로 제작해 이미지 추가해두었습니다.
image

@t1nm1ksun t1nm1ksun self-assigned this Nov 25, 2024
@t1nm1ksun t1nm1ksun added the feat label Nov 25, 2024
Comment on lines +19 to +23
@SerialName("title") val title: String,
@SerialName("author") val author: String,
@SerialName("image") val image: String?,
@SerialName("genre") val genre: String,
@SerialName("promotion") val promotion: String
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 한줄 취향 마음에 드네요 저랑 같아서 ㅋ. ㅋ

Copy link
Collaborator

@jm991014 jm991014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셧쑴다~ 나중에 로그만 지우면 될 거 같아용~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 웹툰 검색 API 연동
2 participants