Skip to content

Commit

Permalink
[PFMENG-1145] Release IAM module from version 4 aws provider (#16)
Browse files Browse the repository at this point in the history
  • Loading branch information
paul-ylz authored Oct 5, 2023
1 parent 21d20f3 commit 919ba06
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ jobs:
uses: SPHTech-Platform/reusable-workflows/.github/workflows/terraform.yaml@main
with:
upload_sarif: false
checkov_skip_check: CKV_TF_1,CKV_AWS_338
2 changes: 2 additions & 0 deletions modules/cluster/data.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ data "aws_region" "current" {}
data "aws_caller_identity" "current" {}

data "aws_iam_policy_document" "cloudwatch_logs_allow_kms" {
#checkov:skip=CKV_AWS_356: Accept risk of using wildcard resource

statement {
sid = "Enable IAM User Permissions"
effect = "Allow"
Expand Down
2 changes: 2 additions & 0 deletions modules/cluster/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ resource "aws_kms_key" "cloudwatch" {


resource "aws_kms_key" "cluster" {
#checkov:skip=CKV2_AWS_64:Accept risk of no KMS key policy

description = "Key for data between the local client and the container"
enable_key_rotation = true
deletion_window_in_days = 7
Expand Down
3 changes: 1 addition & 2 deletions modules/iam/versions.tf
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
terraform {
required_version = ">= 1.3"
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 4.0"
version = ">= 4.0"
}
}
}
2 changes: 2 additions & 0 deletions modules/service/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ data "aws_ecs_task_definition" "this" {
}

resource "aws_ecs_service" "this" {
#checkov:skip=CKV_AWS_332: Already defaulting to latest FARGATE platform version

name = var.name
cluster = var.cluster_id

Expand Down

0 comments on commit 919ba06

Please sign in to comment.