Skip to content

Commit

Permalink
chore: skip checkov CKV_AWS_318
Browse files Browse the repository at this point in the history
  • Loading branch information
abhinavkumarsph committed Jul 10, 2024
1 parent c44562d commit dff0d03
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 12 deletions.
4 changes: 0 additions & 4 deletions examples/opensearch/data.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ data "aws_cloudformation_export" "web_subnet_b" {
name = var.cf_export_web_subnet_b
}

data "aws_cloudformation_export" "web_subnet_c" {
name = var.cf_export_web_subnet_c
}

data "aws_cloudformation_export" "app_sg_id" {
name = var.cf_export_app_sg_id
}
1 change: 0 additions & 1 deletion examples/opensearch/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ module "opensearch" {
vpc_endpoint_subnet_ids = [
data.aws_cloudformation_export.web_subnet_a.value,
data.aws_cloudformation_export.web_subnet_b.value,
data.aws_cloudformation_export.web_subnet_c.value,
]
vpc_endpoint_security_group_ids = [
data.aws_cloudformation_export.app_sg_id.value,
Expand Down
8 changes: 1 addition & 7 deletions examples/opensearch/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ variable "engine_version" {
variable "instance_count" {
description = "OpenSearch instance count"
type = number
default = 3
default = 2
}

variable "instance_type" {
Expand All @@ -34,12 +34,6 @@ variable "cf_export_web_subnet_b" {
default = "subnetIDWebB-ap-southeast-1"
}

variable "cf_export_web_subnet_c" {
description = "cf_export_web_subnet_c"
type = string
default = "subnetIDWebC-ap-southeast-1"
}

variable "cf_export_app_sg_id" {
description = "app security group id"
type = string
Expand Down
2 changes: 2 additions & 0 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ resource "aws_opensearch_domain" "this" {
#checkov:skip=CKV2_AWS_52
#checkov:skip=CKV_AWS_248:Ensure that Elasticsearch is not using the default Security Group
#checkov:skip=CKV_AWS_317:Ensure Elasticsearch Domain Audit Logging is enabled
#checkov:skip=CKV_AWS_318:Ensure Elasticsearch domains are configured with at least three dedicated master nodes for HA

# service linked role must exist and default cloudwatch log_group created.
depends_on = [
aws_iam_service_linked_role.aos,
Expand Down

0 comments on commit dff0d03

Please sign in to comment.