Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: option to disable index slow logs #44

Merged
merged 5 commits into from
May 27, 2024
Merged

fix: option to disable index slow logs #44

merged 5 commits into from
May 27, 2024

Conversation

abhinavkumarsph
Copy link
Contributor

@abhinavkumarsph abhinavkumarsph commented May 21, 2024 •
edited
Loading

Fix for: #43

  • Option to override index_slow_logs creation
  • If cloudwatch_log_group_arn is specified, skip log group creation
  • TF lint/Checkov fixes

@abhinavkumarsph abhinavkumarsph requested review from a team, jaezeu, gowripadmajas and conston-sph and removed request for a team May 21, 2024 02:41
@abhinavkumarsph abhinavkumarsph linked an issue May 21, 2024 that may be closed by this pull request
Can't disable Cloudwatch Logs #43
Closed
@abhinavkumarsph abhinavkumarsph requested a review from hong-yi May 21, 2024 02:42
@abhinavkumarsph abhinavkumarsph requested a review from a team May 21, 2024 02:48
@abhinavkumarsph abhinavkumarsph added bug Something isn't working fix Bug fix and removed bug Something isn't working labels May 27, 2024
@abhinavkumarsph abhinavkumarsph merged commit cc2f02b into main May 27, 2024
5 checks passed
@abhinavkumarsph abhinavkumarsph deleted the fix-cant-disable-index-slow-logs branch May 27, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niroz89 niroz89 niroz89 approved these changes

@jaezeu jaezeu Awaiting requested review from jaezeu jaezeu was automatically assigned from SPHTech-Platform/platform-engineering

@gowripadmajas gowripadmajas Awaiting requested review from gowripadmajas gowripadmajas was automatically assigned from SPHTech-Platform/platform-engineering

@conston-sph conston-sph Awaiting requested review from conston-sph conston-sph was automatically assigned from SPHTech-Platform/platform-engineering

@hong-yi hong-yi Awaiting requested review from hong-yi

Assignees
No one assigned
Labels
fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't disable Cloudwatch Logs
2 participants
@abhinavkumarsph @niroz89