Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix / usage section of README.md #2

Merged
merged 9 commits into from
Dec 12, 2023
Merged

fix / usage section of README.md #2

merged 9 commits into from
Dec 12, 2023

Conversation

hazmei
Copy link
Collaborator

@hazmei hazmei commented Dec 8, 2023 •
edited
Loading

  1. Fix a error in the usage section of the README documentation.
  2. Added a comment to ensure that user is aware that secret associations needs to be removed before sync destination can be remove.

@hazmei hazmei requested a review from shisheng10 December 12, 2023 01:09
@hazmei hazmei enabled auto-merge (squash) December 12, 2023 01:09
shisheng10
shisheng10 reviewed Dec 12, 2023
View reviewed changes
hazmei and others added 5 commits December 12, 2023 09:31
@hazmei @shisheng10
Update README.md
c807336 
Co-authored-by: Shi Sheng <[email protected]>
@hazmei @shisheng10
Update README.md
ab7f642 
Co-authored-by: Shi Sheng <[email protected]>
@hazmei @shisheng10
Update README.md
e23299e 
Co-authored-by: Shi Sheng <[email protected]>
@hazmei @shisheng10
Update README.md
a658415 
Co-authored-by: Shi Sheng <[email protected]>
@hazmei @shisheng10
Update README.md
a00ef1f 
Co-authored-by: Shi Sheng <[email protected]>
@hazmei hazmei requested a review from shisheng10 December 12, 2023 01:32
@shisheng10
Copy link

For line 30, can update to the following:

Remove some vault secrets from association by adding the attribute unassociate_secrets:

shisheng10
shisheng10 reviewed Dec 12, 2023
View reviewed changes
@shisheng10
Copy link

For line 62, can update to the following:

Remove all vault secrets from association by adding the attribute delete_all_secret_associations = true:

@hazmei hazmei requested a review from shisheng10 December 12, 2023 03:36
shisheng10
shisheng10 approved these changes Dec 12, 2023
View reviewed changes
Copy link

@shisheng10 shisheng10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hazmei hazmei merged commit 0029a99 into main Dec 12, 2023
@hazmei hazmei deleted the fix/usage-section-readme branch December 12, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shisheng10 shisheng10 shisheng10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hazmei @shisheng10