Skip to content

Commit

Permalink
Merge pull request #64 from Kariton/port-fixer-livenessProbe
Browse files Browse the repository at this point in the history
  • Loading branch information
SQLJames authored Nov 7, 2024
2 parents bb15e22 + 5253358 commit a4e4e5e
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 8 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
## Changelog

### V2.2.2

#### Non-Breaking Changes

- Disabled port-fixer livenessProbe due to reliability issues

### V2.2.1

#### Non-Breaking Changes
Expand Down
2 changes: 1 addition & 1 deletion charts/factorio-server-charts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ sources:
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 2.2.1
version: 2.2.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
17 changes: 10 additions & 7 deletions charts/factorio-server-charts/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -218,13 +218,16 @@ spec:
- --ip=127.0.0.1
- --port=34197
- --remotePort={{ .Values.port_fixer.port | default .Values.service.port }}
livenessProbe:
httpGet:
path: /health
port: port-fixer
periodSeconds: 10
initialDelaySeconds: 5
failureThreshold: 3
#
# Disabled due to reliability issues: https://github.com/ZCube/factorio-port-fixer/issues/1
#
# livenessProbe:
# httpGet:
# path: /health
# port: port-fixer
# periodSeconds: 10
# initialDelaySeconds: 5
# failureThreshold: 3
ports:
- name: port-fixer
containerPort: 34197
Expand Down

0 comments on commit a4e4e5e

Please sign in to comment.