Merge pull request #68 from SQLJames/feature/decouplingHostNetwork

decoupling the hostnetwork from nodeport service designation
SQLJames · Nov 8, 2024 · f3a6387 · f3a6387
2 parents f76d1d0 + ab58bfd
commit f3a6387
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 ## Changelog
 
+### V2.3.0
+
+#### Non-Breaking Changes
+
+- Decoupling hostNetworking from the nodePort service. Introduces hostNetworkEnabled in the base of the values. By default this will still enabled with a standard set of values, but can be individually disabled if needed. [Issue 38](https://github.com/SQLJames/factorio-server-charts/issues/38)
+
 ### V2.2.4
 
 #### Non-Breaking Changes

diff --git a/charts/factorio-server-charts/Chart.yaml b/charts/factorio-server-charts/Chart.yaml
@@ -20,7 +20,7 @@ sources:
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 2.2.4
+version: 2.3.0
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

diff --git a/charts/factorio-server-charts/templates/deployment.yaml b/charts/factorio-server-charts/templates/deployment.yaml
@@ -23,10 +23,8 @@ spec:
         options:
           - name: ndots
             value: '1'
-      {{- if eq .Values.service.type "NodePort" }}
+      {{- if .Values.hostNetworkEnabled }}
       hostNetwork: true
-      {{- else }}
-      hostNetwork: false
       {{- end }}
       initContainers:
         - name: volume-permissions-serversettingsconfig

diff --git a/charts/factorio-server-charts/values.yaml b/charts/factorio-server-charts/values.yaml
@@ -12,6 +12,8 @@
 
 replicaCount: 1
 
+hostNetworkEnabled: true
+
 securityContext:
   runAsUser: 0