Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: added sshd config and service utilities #71

Merged
merged 1 commit into from
Feb 9, 2024
Merged

utils: added sshd config and service utilities #71

merged 1 commit into from
Feb 9, 2024

Conversation

danlavu
Copy link

@danlavu danlavu commented Jan 19, 2024

No description provided.

@danlavu danlavu added the enhancement New feature or request label Jan 19, 2024
@danlavu danlavu self-assigned this Jan 19, 2024
@danlavu danlavu force-pushed the sshd branch 3 times, most recently from 926d0c8 to 648b8b3 Compare January 19, 2024 13:30
@danlavu danlavu requested review from pbrezina and ikerexxe January 19, 2024 13:31
@danlavu danlavu marked this pull request as draft January 19, 2024 21:36
@danlavu danlavu force-pushed the sshd branch 2 times, most recently from 379e63c to 8b70e03 Compare January 21, 2024 03:54
@danlavu danlavu marked this pull request as ready for review January 21, 2024 03:57
ikerexxe
ikerexxe reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, everything else looks good.

@danlavu danlavu marked this pull request as draft January 22, 2024 21:50
@danlavu danlavu marked this pull request as ready for review January 22, 2024 21:50
@andreboscatto andreboscatto assigned ikerexxe and pbrezina and unassigned danlavu Jan 25, 2024
ikerexxe
ikerexxe previously approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@ikerexxe ikerexxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the patch

pbrezina
pbrezina requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@pbrezina pbrezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dan, please, see minor change in the doc string. Otherwise LGTM. I don't plan to test it, I trust that the code works for you.

@danlavu
Copy link
Author

danlavu commented Jan 30, 2024 •
edited
Loading

@pbrezina works for me; docstring is fixed.

@pbrezina
Copy link
Member

pbrezina commented Feb 5, 2024

@danlavu Remove the merge commit please.

@danlavu
Copy link
Author

danlavu commented Feb 5, 2024

@danlavu Remove the merge commit please.

Done.

pbrezina
pbrezina requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@pbrezina pbrezina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also how is this going to be used? Wouldn't it be maybe better to create new instance of sshd listening on different port so you don't meddle with ssh connections that we use to talk to the host?

@danlavu danlavu force-pushed the sshd branch 2 times, most recently from c486e5b to da19020 Compare February 8, 2024 17:15
@danlavu danlavu marked this pull request as draft February 9, 2024 04:53
@danlavu danlavu marked this pull request as ready for review February 9, 2024 05:31
pbrezina
pbrezina requested changes Feb 9, 2024
View reviewed changes
@pbrezina pbrezina merged commit 95f9d9c into SSSD:master Feb 9, 2024
3 of 5 checks passed
@danlavu danlavu deleted the sshd branch April 17, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrezina pbrezina pbrezina requested changes

@ikerexxe ikerexxe ikerexxe left review comments

Assignees

@ikerexxe ikerexxe

@pbrezina pbrezina

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danlavu @pbrezina @ikerexxe