Further restriction of child processes capabilities (part 2) #7703
+250
−1,262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-tikhonov
force-pushed
the
caps-again-krb5
branch
from
7d59fca
to
37f548a
Compare
alexey-tikhonov
force-pushed
the
caps-again-krb5
branch
4 times, most recently
from
8f69432
to
636f01e
Compare
alexey-tikhonov
force-pushed
the
caps-again-krb5
branch
10 times, most recently
from
bdb1f05
to
ba7180a
Compare
to match 'kinit' behavior and avoid the need for cap_chown and cap_dac_override.
Since 'krb5_child' has lost set-id bit and is run under uid/gid of the backend, it was a no-op.
Set user uid/gid as real IDs as a first step in `privileged_krb5_setup()` and drop cap_set*id afterwards. Having real_ids == user_ids and set_ids == service_ids should be enough to switch thru and back.
alexey-tikhonov
force-pushed
the
caps-again-krb5
branch
from
ba7180a
to
8c77229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimizes capabilities required by 'krb5_child'.