Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Fixed widget bug for staging rules #58

Merged
merged 9 commits into from
Nov 21, 2024
Merged

♻️ Fixed widget bug for staging rules #58

merged 9 commits into from
Nov 21, 2024

Conversation

babakamyljanovssw
Copy link
Member

@babakamyljanovssw babakamyljanovssw commented Nov 20, 2024 •
edited
Loading

Issue: SSWConsulting/SSW.Rules#1642

❌ Pain: SW Staging Rules was failing to display widget.

  • Updated URLs
  • Added condition checks so it will use correct URLs for getting history.json and commits.json.
  • Updated .env.template
  • Improved documentation

@babakamyljanovssw babakamyljanovssw self-assigned this Nov 20, 2024
JackDevAU
JackDevAU previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@JackDevAU JackDevAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@babakamyljanovssw babakamyljanovssw merged commit 860cab4 into main Nov 21, 2024
@babakamyljanovssw babakamyljanovssw deleted the fix-staging branch November 21, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackDevAU JackDevAU JackDevAU approved these changes

@bradystroud bradystroud Awaiting requested review from bradystroud

Assignees

@babakamyljanovssw babakamyljanovssw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babakamyljanovssw @JackDevAU