Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics/additional random access #507

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

SSoelvsten
Copy link
Owner

@SSoelvsten SSoelvsten commented Jun 2, 2023

Closes #494 (and closes #506 that it exposes)

@SSoelvsten SSoelvsten added 📁 build CMake, GitHub Actions etc. 📁 statistics In the name of science! labels Jun 2, 2023
@SSoelvsten SSoelvsten self-assigned this Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 90.625% and project coverage change: -0.090 ⚠️

Comparison is base (dd51d8f) 97.308% compared to head (9799b7b) 97.218%.

Additional details and impacted files
@@              Coverage Diff              @@
##              main      #507       +/-   ##
=============================================
- Coverage   97.308%   97.218%   -0.090%     
=============================================
  Files           82        82               
  Lines         4866      4924       +58     
=============================================
+ Hits          4735      4787       +52     
- Misses         131       137        +6     
Impacted Files Coverage Δ
src/adiar/internal/io/node_file.h 100.000% <ø> (ø)
src/adiar/statistics.cpp 88.663% <87.500%> (-0.337%) ⬇️
src/adiar/internal/io/arc_writer.h 100.000% <100.000%> (ø)
src/adiar/internal/io/node_writer.h 100.000% <100.000%> (ø)
src/adiar/statistics.h 100.000% <100.000%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SSoelvsten
Copy link
Owner Author

The lack of coverage is due to the skipped "Not Run" prints

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Benchmark Report 🟢

origin/statistics/additional-random-access is an improvement of 1.40% (compared to origin/main).

Minimum running time (s) for 9-Queens:

origin/main origin/statistics/additional-random-access
0.26 0.26
Raw Data

Running times (s) for 9-Queens:

origin/main origin/statistics/additional-random-access
0.26 0.26
0.27 0.28
0.27 0.28
0.34 0.27
0.27 0.28
0.28 0.26
0.27 0.27
0.27 0.27
0.27 0.28
0.27 0.27
0.33 0.26
0.27 0.27
0.27 0.27
0.27 0.27
0.35 0.27
0.27 0.33

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Benchmark Report 🟢

origin/statistics/additional-random-access is an improvement of 0.07% (compared to origin/main).

Minimum running time (s) for 12-Queens:

origin/main origin/statistics/additional-random-access
14.56 14.55
Raw Data

Running times (s) for 12-Queens:

origin/main origin/statistics/additional-random-access
14.77 14.60
14.71 14.72
14.59 14.59
14.59 14.55
14.56 14.62
14.58 14.62
14.56 14.68
14.58 14.61
14.62 14.64
14.75 14.62
14.78 14.62
14.57 14.70
14.56 14.63
14.60 14.60
14.59 14.73
14.75 14.65

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Benchmark Report 🟢

origin/statistics/additional-random-access is an improvement of 0.60% (compared to origin/main).

Minimum running time (s) for 14-Queens:

origin/main origin/statistics/additional-random-access
418.74 416.23
Raw Data

Running times (s) for 14-Queens:

origin/main origin/statistics/additional-random-access
556.59 422.47
419.88 416.23
418.74 416.94
419.29 416.86

@SSoelvsten SSoelvsten merged commit bed52c7 into main Jun 2, 2023
@SSoelvsten SSoelvsten deleted the statistics/additional-random-access branch June 3, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 build CMake, GitHub Actions etc. 📁 statistics In the name of science!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Statistics when Client Program Lacks ADIAR_STATS Additional random-access statistics
1 participant