Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding hierarchical operation to index_queue spawning #6318

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding hierarchical operation to index_queue spawning #6318

wants to merge 3 commits into from
+233 −94

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Aug 7, 2023

  • flyby: fixing integral conversion warnings

@hkaiser hkaiser added this to the 1.10.0 milestone Aug 7, 2023
@hkaiser hkaiser force-pushed the hierarchical_index_queue_spawning branch 5 times, most recently from 1d0105a to 5ec4143 Compare August 8, 2023 12:46
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)??(=)

Info

PropertyBeforeAfter
HPX Commitdcb54153a5942b
HPX Datetime2023-05-10T12:07:53+00:002023-08-08T12:46:07+00:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Datetime2023-05-10T14:50:18.616050-05:002023-08-08T07:56:30.375986-05:00
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch=

Info

PropertyBeforeAfter
HPX Commitdcb54153a5942b
HPX Datetime2023-05-10T12:07:53+00:002023-08-08T12:46:07+00:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Datetime2023-05-10T14:52:35.047119-05:002023-08-08T07:58:44.952518-05:00
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)---(=)
Stream Benchmark - Scale(=)---(=)
Stream Benchmark - Triad(=)---(=)
Stream Benchmark - Copy(=)---(=)

Info

PropertyBeforeAfter
HPX Commitdcb54153a5942b
HPX Datetime2023-05-10T12:07:53+00:002023-08-08T12:46:07+00:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Datetime2023-05-10T14:52:52.237641-05:002023-08-08T07:59:02.831317-05:00
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Clusternamerostamrostam

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser hkaiser force-pushed the hierarchical_index_queue_spawning branch 3 times, most recently from f71cb53 to 323ea9b Compare August 8, 2023 13:58
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)??(=)

Info

PropertyBeforeAfter
HPX Commitdcb5415f8b5f11
HPX Datetime2023-05-10T12:07:53+00:002023-08-08T13:58:49+00:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Envfile
Datetime2023-05-10T14:50:18.616050-05:002023-08-08T09:05:54.505281-05:00
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch=

Info

PropertyBeforeAfter
HPX Commitdcb5415f8b5f11
HPX Datetime2023-05-10T12:07:53+00:002023-08-08T13:58:49+00:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Envfile
Datetime2023-05-10T14:52:35.047119-05:002023-08-08T09:08:08.378620-05:00
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add=(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)-(=)

Info

PropertyBeforeAfter
HPX Commitdcb5415f8b5f11
HPX Datetime2023-05-10T12:07:53+00:002023-08-08T13:58:49+00:00
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Envfile
Datetime2023-05-10T14:52:52.237641-05:002023-08-08T09:08:25.204288-05:00
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser hkaiser force-pushed the hierarchical_index_queue_spawning branch from 323ea9b to 090cb5c Compare August 8, 2023 16:34
@hkaiser
Copy link
Member Author

hkaiser commented Aug 9, 2023

retest lsu

@hkaiser hkaiser force-pushed the hierarchical_index_queue_spawning branch from 090cb5c to 0bb7299 Compare August 20, 2023 21:27
@hkaiser hkaiser force-pushed the hierarchical_index_queue_spawning branch from f8d28e9 to c8411d1 Compare August 28, 2023 15:38
@hkaiser hkaiser force-pushed the hierarchical_index_queue_spawning branch from c8411d1 to d018a31 Compare February 12, 2024 20:56
@codacy-production Codacy Production
Copy link

codacy-production bot commented Feb 13, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.02% ✅ 69.92%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e977ecc) 217975 185525 85.11%
Head commit (60e255e) 190960 (-27015) 162576 (-22949) 85.14% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6318) 123 86 69.92%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@hkaiser hkaiser force-pushed the hierarchical_index_queue_spawning branch from d018a31 to 71c796b Compare April 6, 2024 22:39
@hkaiser
Adding hierarchical operation to index_queue spawning
55d44ef 
- flyby: fixing integral conversion warnings
- flyby: fixing target.num_pus
@hkaiser
Split tests to avoid OOM on CircleCI
802eb72
@hkaiser hkaiser force-pushed the hierarchical_index_queue_spawning branch from d4c08e8 to e4c6899 Compare April 28, 2024 16:26
@hkaiser hkaiser force-pushed the hierarchical_index_queue_spawning branch from e4c6899 to 60e255e Compare April 28, 2024 16:33
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)--

Info

PropertyBeforeAfter
HPX Commitd27ac2e02ec247
HPX Datetime2024-03-18T14:00:30+00:002024-04-28T16:33:59+00:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Envfile
Clusternamerostamrostam
Datetime2024-03-18T09:18:04.949759-05:002024-04-28T11:46:23.921602-05:00

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Commitd27ac2e02ec247
HPX Datetime2024-03-18T14:00:30+00:002024-04-28T16:33:59+00:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Envfile
Clusternamerostamrostam
Datetime2024-03-18T09:19:53.062988-05:002024-04-28T11:48:11.682623-05:00

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add=(=)(=)
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)=(=)

Info

PropertyBeforeAfter
HPX Commitd27ac2e02ec247
HPX Datetime2024-03-18T14:00:30+00:002024-04-28T16:33:59+00:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Envfile
Clusternamerostamrostam
Datetime2024-03-18T09:20:13.002391-05:002024-04-28T11:48:30.275490-05:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser hkaiser modified the milestones: 1.10.0, 1.11.0 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: executors type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hkaiser @StellarBot