Simd sort #6326

Johan511 · 2023-08-19T13:19:39Z

Enabling vectorization for sorting using 3rd party library (https://github.com/intel/x86-simd-sort)

(Work in Progress)

StellarBot · 2023-08-19T13:28:29Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	??	-

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-19T13:19:41+00:00
HPX Commit	`dcb5415`	`cd65a80`
Clustername	rostam	rostam
Envfile
Datetime	2023-05-10T14:50:18.616050-05:00	2023-08-19T08:25:36.834748-05:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	=

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-19T13:19:41+00:00
HPX Commit	`dcb5415`	`cd65a80`
Clustername	rostam	rostam
Envfile
Datetime	2023-05-10T14:52:35.047119-05:00	2023-08-19T08:27:50.442351-05:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	(=)
Stream Benchmark - Scale	(=)	(=)	=
Stream Benchmark - Triad	(=)	(=)	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-19T13:19:41+00:00
HPX Commit	`dcb5415`	`cd65a80`
Clustername	rostam	rostam
Envfile
Datetime	2023-05-10T14:52:52.237641-05:00	2023-08-19T08:28:07.336369-05:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

CMakeLists.txt

cmake/HPX_SetupSimdSort.cmake

StellarBot · 2023-08-19T18:48:13Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	??	-

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-19T18:38:27+00:00
HPX Commit	`dcb5415`	`24dfcd5`
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clustername	rostam	rostam
Datetime	2023-05-10T14:50:18.616050-05:00	2023-08-19T13:45:18.850938-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	(=)

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-19T18:38:27+00:00
HPX Commit	`dcb5415`	`24dfcd5`
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clustername	rostam	rostam
Datetime	2023-05-10T14:52:35.047119-05:00	2023-08-19T13:47:31.102556-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	(=)
Stream Benchmark - Scale	(=)	(=)	(=)
Stream Benchmark - Triad	(=)	(=)	(=)
Stream Benchmark - Copy	(=)	(=)	(=)

Info

Property	Before	After
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-19T18:38:27+00:00
HPX Commit	`dcb5415`	`24dfcd5`
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clustername	rostam	rostam
Datetime	2023-05-10T14:52:52.237641-05:00	2023-08-19T13:47:48.033631-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

cmake/FindSimdSort.cmake

cmake/HPX_SetupSimdSort.cmake

StellarBot · 2023-08-29T06:34:04Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	??	(=)

Info

Property	Before	After
HPX Commit	`dcb5415`	`b60c175`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-29T06:23:47+00:00
Clustername	rostam	rostam
Datetime	2023-05-10T14:50:18.616050-05:00	2023-08-29T01:31:05.004560-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	(=)

Info

Property	Before	After
HPX Commit	`dcb5415`	`b60c175`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-29T06:23:47+00:00
Clustername	rostam	rostam
Datetime	2023-05-10T14:52:35.047119-05:00	2023-08-29T01:33:17.791388-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	(=)
Stream Benchmark - Scale	=	(=)	=
Stream Benchmark - Triad	(=)	=	(=)
Stream Benchmark - Copy	(=)	-	(=)

Info

Property	Before	After
HPX Commit	`dcb5415`	`b60c175`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-29T06:23:47+00:00
Clustername	rostam	rostam
Datetime	2023-05-10T14:52:52.237641-05:00	2023-08-29T01:33:34.692225-05:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

Johan511 · 2023-08-29T21:03:12Z

Speedup observed for simd-sort

Johan511 · 2023-08-29T21:16:43Z

@hkaiser There are multiple issues trying to add this integrate this feature into HPX

We need to add feature tests for AVX512
Some vector intrinsic functions are not supported in certain architectures and as a result throw errors. In case of medusa a certain vector load instruction related to 16bit integers was not supported which leads to compile time failure of the target application even if i16 is not being sorted
similar to 2nd point, some architectures might not support certain datatypes (Eg: _Float16) which can cause compile time failures in HPX
If HPX is compiled with simd sort, the target application must be compiled with -march=native (or all the required flags to support vectorization). Else the compilation of the target application will fail

The library has different files for sorting 16bit, 32bit, 64bit numbers, I was considering adding a feature test for each of these files and including them with ifdef guards around them. This would still be an issue if the user compiles HPX and the HPX application (target) and different architectures. This might also lead to some false positives (features which are supported might not be available to user).

I would like your opinion on if I should proceed with the above design.

StellarBot · 2023-08-29T22:00:33Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	??	(=)

Info

Property	Before	After
HPX Commit	`dcb5415`	`0c93a3b`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-29T21:45:09+00:00
Clustername	rostam	rostam
Datetime	2023-05-10T14:50:18.616050-05:00	2023-08-29T16:57:31.036372-05:00
Envfile
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	(=)

Info

Property	Before	After
HPX Commit	`dcb5415`	`0c93a3b`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-29T21:45:09+00:00
Clustername	rostam	rostam
Datetime	2023-05-10T14:52:35.047119-05:00	2023-08-29T16:59:43.227039-05:00
Envfile
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	(=)
Stream Benchmark - Scale	(=)	(=)	=
Stream Benchmark - Triad	(=)	(=)	(=)
Stream Benchmark - Copy	(=)	-	(=)

Info

Property	Before	After
HPX Commit	`dcb5415`	`0c93a3b`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-29T21:45:09+00:00
Clustername	rostam	rostam
Datetime	2023-05-10T14:52:52.237641-05:00	2023-08-29T17:00:00.111855-05:00
Envfile
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2023-08-29T22:10:49Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	(=)	??	(=)

Info

Property	Before	After
HPX Commit	`dcb5415`	`25b4e45`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-29T21:58:26+00:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Datetime	2023-05-10T14:50:18.616050-05:00	2023-08-29T17:07:47.004681-05:00

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	(=)

Info

Property	Before	After
HPX Commit	`dcb5415`	`25b4e45`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-29T21:58:26+00:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Datetime	2023-05-10T14:52:35.047119-05:00	2023-08-29T17:09:59.091186-05:00

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	(=)	(=)	(=)
Stream Benchmark - Scale	(=)	(=)	(=)
Stream Benchmark - Triad	(=)	(=)	(=)
Stream Benchmark - Copy	(=)	-	(=)

Info

Property	Before	After
HPX Commit	`dcb5415`	`25b4e45`
HPX Datetime	2023-05-10T12:07:53+00:00	2023-08-29T21:58:26+00:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Datetime	2023-05-10T14:52:52.237641-05:00	2023-08-29T17:10:15.975599-05:00

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

codacy-production · 2023-09-14T15:39:02Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
-69.13%	∅

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`103a7b8`)	190583	162311	85.17%
Head commit (`1c18b4a`)	188842 (-1741)	30284 (-132027)	16.04% (-69.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6326)	0	0	∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

Co-authored-by: Hartmut Kaiser <[email protected]>

Signed-off-by: Hari Hara Naveen S <[email protected]>

Johan511 requested review from aurianer, biddisco, hkaiser and msimberg as code owners August 19, 2023 13:19

hkaiser added type: enhancement category: algorithms labels Aug 19, 2023

hkaiser added this to the 1.10.0 milestone Aug 19, 2023

hkaiser added the type: compatibility issue label Aug 19, 2023

hkaiser requested changes Aug 19, 2023

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

cmake/HPX_SetupSimdSort.cmake Outdated Show resolved Hide resolved

cmake/HPX_SetupSimdSort.cmake Outdated Show resolved Hide resolved

hkaiser requested changes Aug 21, 2023

View reviewed changes

cmake/FindSimdSort.cmake Outdated Show resolved Hide resolved

cmake/HPX_SetupSimdSort.cmake Outdated Show resolved Hide resolved

Johan511 force-pushed the simd-sort branch from e43b6fa to 88a8292 Compare September 13, 2023 17:07

STEllAR-GROUP deleted a comment from codacy-production bot Sep 13, 2023

Johan511 and others added 10 commits October 19, 2023 09:42

pulls simd sort

a2a7930

cmake format

fb85580

Update CMakeLists.txt

fd13408

Co-authored-by: Hartmut Kaiser <[email protected]>

Update CMakeLists.txt

8c88a48

Co-authored-by: Hartmut Kaiser <[email protected]>

Update cmake/HPX_SetupSimdSort.cmake

66835a0

Co-authored-by: Hartmut Kaiser <[email protected]>

Update cmake/HPX_SetupSimdSort.cmake

4b199bc

Co-authored-by: Hartmut Kaiser <[email protected]>

simd sort fetched as intended

82d1537

simd sort

058d428

fixed inspect errors

1f92c0f

fixed missing header

07f9d20

Johan511 added 9 commits October 19, 2023 09:42

examples throwing linker error

4e315b9

Signed-off-by: Hari Hara Naveen S <[email protected]>

added compile definitions for simd sort

2ef7872

Signed-off-by: Hari Hara Naveen S <[email protected]>

integrated simd sort

f158dda

Signed-off-by: Hari Hara Naveen S <[email protected]>

added missing config file

9493bce

Signed-off-by: Hari Hara Naveen S <[email protected]>

fixed typo

3db90f7

Signed-off-by: Hari Hara Naveen S <[email protected]>

fixing unused param error

42562a0

Signed-off-by: Hari Hara Naveen S <[email protected]>

changed native arch to avx512f

4768761

Signed-off-by: Hari Hara Naveen S <[email protected]>

better diagnostic

25534b3

Signed-off-by: Hari Hara Naveen S <[email protected]>

return 0 added

1c18b4a

Signed-off-by: Hari Hara Naveen S <[email protected]>

Johan511 force-pushed the simd-sort branch from f3d39fa to 1c18b4a Compare October 19, 2023 14:46

msimberg removed request for msimberg, biddisco and aurianer November 1, 2023 08:35

hkaiser modified the milestones: 1.10.0, 1.11.0 May 3, 2024

Simd sort #6326

Are you sure you want to change the base?

Simd sort #6326

Conversation

Johan511 commented Aug 19, 2023 • edited Loading

StellarBot commented Aug 19, 2023

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Aug 19, 2023

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Aug 29, 2023

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

Johan511 commented Aug 29, 2023 • edited Loading

Johan511 commented Aug 29, 2023 • edited Loading

StellarBot commented Aug 29, 2023

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Aug 29, 2023

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

codacy-production bot commented Sep 14, 2023 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Johan511 commented Aug 19, 2023 •

edited

Loading

Johan511 commented Aug 29, 2023 •

edited

Loading

Johan511 commented Aug 29, 2023 •

edited

Loading

codacy-production bot commented Sep 14, 2023 •

edited

Loading