Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return outermost thread id #6413

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Always return outermost thread id #6413

merged 1 commit into from
Mar 25, 2024

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jan 12, 2024

-flyby: deprecate get_outer_self_id

fixing #6333

Copy link

codacy-production bot commented Jan 13, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% 91.39%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5a0ba83) 215961 183719 85.07%
Head commit (a627ae2) 190554 (-25407) 162178 (-21541) 85.11% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6413) 244 223 91.39%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@hkaiser hkaiser force-pushed the fixing_6333 branch 4 times, most recently from 196ce45 to 2aba827 Compare January 17, 2024 15:11
@hkaiser
Copy link
Member Author

hkaiser commented Jan 18, 2024

retest lsu

@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)??-

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-01-18T15:34:29+00:00
HPX Commitdcb5415f1abe26
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Datetime2023-05-10T14:50:18.616050-05:002024-01-18T09:39:59.830539-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch=

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-01-18T15:34:29+00:00
HPX Commitdcb5415f1abe26
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Datetime2023-05-10T14:52:35.047119-05:002024-01-18T09:42:13.571711-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale+(=)(=)
Stream Benchmark - Triad(=)=(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-01-18T15:34:29+00:00
HPX Commitdcb5415f1abe26
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1
Clusternamerostamrostam
Datetime2023-05-10T14:52:52.237641-05:002024-01-18T09:42:30.389000-06:00
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

-flyby: deprecate get_outer_self_id
-flyby: ignoring locks during termination detection
@hkaiser
Copy link
Member Author

hkaiser commented Mar 20, 2024

The freelist error has been fixed by #6458

@hkaiser hkaiser merged commit 2a3fbdd into master Mar 25, 2024
60 of 74 checks passed
@hkaiser hkaiser deleted the fixing_6333 branch March 25, 2024 21:31
@hkaiser hkaiser restored the fixing_6333 branch March 26, 2024 14:26
@hkaiser hkaiser deleted the fixing_6333 branch March 26, 2024 14:26
@Pansysk75 Pansysk75 restored the fixing_6333 branch March 27, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants