Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nvcc crashes in transform_stream.cu and synchronize.cu #6452

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

G-071
Copy link
Member

@G-071 G-071 commented Mar 13, 2024

With CUDA 12.3 nvcc does not outright crash anymore when compiling sender-receiver code.
Though, to make them compile, we still need to conditionally remove the noexcept with an IFDEF, which this PR adds.

Hence, we can activate the synchronize and the transform_stream tests when the CUDA version ist 12.3 and newer.

Fixes #5799

@G-071 G-071 requested a review from hkaiser as a code owner March 13, 2024 22:29
@StellarBot
Copy link

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)??(=)

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-03-13T22:29:13+00:00
HPX Commitdcb54158017369
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2023-05-10T14:50:18.616050-05:002024-03-13T17:35:00.370890-05:00
Envfile
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch+++

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-03-13T22:29:13+00:00
HPX Commitdcb54158017369
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2023-05-10T14:52:35.047119-05:002024-03-13T17:36:48.122897-05:00
Envfile
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale+(=)(=)
Stream Benchmark - Triad(=)-(=)
Stream Benchmark - Copy+(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2023-05-10T12:07:53+00:002024-03-13T22:29:13+00:00
HPX Commitdcb54158017369
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Datetime2023-05-10T14:52:52.237641-05:002024-03-13T17:37:04.707585-05:00
Envfile
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

Copy link

codacy-production bot commented Mar 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (716c028) 215961 183719 85.07%
Head commit (3c88a73) 190469 (-25492) 162177 (-21542) 85.15% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6452) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

hkaiser
hkaiser previously approved these changes Mar 18, 2024
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Mar 18, 2024

@G-071 could you please fix the inspect and clang-format issues reported?

@hkaiser
Copy link
Member

hkaiser commented Mar 25, 2024

@G-071 ping?

@G-071
Copy link
Member Author

G-071 commented Mar 26, 2024

Thanks for the ping, I forgot about this PR. It should be fixed now though!

@hkaiser hkaiser merged commit c516c88 into STEllAR-GROUP:master Apr 3, 2024
64 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate CUDA compilation problems
3 participants