lci pp: fix messages larger than INT_MAX #6566

JiakunYan · 2024-11-08T05:31:16Z

Thank @m-diers for reporting the bug. Test program provided by @m-diers

The LCI parcelport did not properly support messages larger than INT_MAX. This PR fixes the HPX side problem. The LCI side problem will be fixed by uiuc-hpc/lci#75 . I will update the default LCI autofetch tag soon.

This PR also adds a test for large messages. @hkaiser, let me know if I put the test program in the right directory.

StellarBot · 2024-11-08T05:42:49Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-08T05:31:18+00:00
HPX Commit	`d27ac2e`	`48a34d9`
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Clustername	rostam	rostam
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-07T23:40:12.533744-06:00
Envfile

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-08T05:31:18+00:00
HPX Commit	`d27ac2e`	`48a34d9`
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Clustername	rostam	rostam
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-07T23:42:03.454929-06:00
Envfile

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	---

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-08T05:31:18+00:00
HPX Commit	`d27ac2e`	`48a34d9`
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Clustername	rostam	rostam
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-07T23:42:23.884893-06:00
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

m-diers · 2024-11-08T05:44:46Z

For your information: The same problem exists with the MPI parcel port.

JiakunYan · 2024-11-08T05:47:18Z

For your information: The same problem exists with the MPI parcel port.

Yeah. I will work on the MPI parcelport later.

codacy-production · 2024-11-08T10:48:18Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.47%	✅ 80.77%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`342d373`)	234436	200546	85.54%
Head commit (`83686d0`)	191442 (-42994)	162863 (-37683)	85.07% (-0.47%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6566)	78	63	80.77%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

hkaiser · 2024-11-08T14:14:13Z

For your information: The same problem exists with the MPI parcel port.

It will most likely exist in all parcelports...

hkaiser · 2024-11-08T14:16:06Z

This PR also adds a test for large messages. @hkaiser, let me know if I put the test program in the right directory.

Since this problem most likely exists in all parcelports, would you mind moving the test to the parcelset module (https://github.com/STEllAR-GROUP/hpx/tree/master/libs/full/parcelset/tests/regressions)?

JiakunYan · 2024-11-08T17:41:47Z

@hkaiser I don't think the ARGS argument of add_hpx_regression_test has any effects?

For example, this test tests.regressions.util.distributed.lci.zero_copy_parcels_1001_no_zero_copy_optimization

The cmake configuration is

  add_hpx_regression_test(
    "util" zero_copy_parcels_1001_no_zero_copy_optimization
    EXECUTABLE zero_copy_parcels_1001
    PSEUDO_DEPS_NAME zero_copy_parcels_1001 ${zero_copy_parcels_1001_PARAMETERS}
    ARGS --hpx:ini=hpx.parcel.zero_copy_optimization=0
  )

But the command line is still

/usr/bin/python3.9 "/work/jenkins/workspace/HPX/hpx/build/gcc-12-debug/bin/hpxrun.py" "/work/jenkins/workspace/HPX/hpx/build/gcc-12-debug/bin/zero_copy_parcels_1001_test" "-e" "0" "-t" "1" "-l" "2" "-p" "lci" "-r" "mpi" "-v" "--" "PSEUDO_DEPS_NAME" "zero_copy_parcels_1001" "--hpx:ini=hpx.parcel.mpi.ack_handshake!=1"

The same happens for my big_parcel_int_max_plus_1 test and that's why the MPI parcelport passed the test.

hkaiser · 2024-11-08T20:18:05Z

add_hpx_regression_test(
"util" zero_copy_parcels_1001_no_zero_copy_optimization
EXECUTABLE zero_copy_parcels_1001
PSEUDO_DEPS_NAME zero_copy_parcels_1001 ${zero_copy_parcels_1001_PARAMETERS}
ARGS --hpx:ini=hpx.parcel.zero_copy_optimization=0
)

Any additional (unparsed) argument passed to add_hpx_regression_test should end up being added to the command line of a test. I.e.

 add_hpx_regression_test(
    "util" zero_copy_parcels_1001_no_zero_copy_optimization
    EXECUTABLE zero_copy_parcels_1001
    PSEUDO_DEPS_NAME zero_copy_parcels_1001 ${zero_copy_parcels_1001_PARAMETERS}
    --hpx:ini=hpx.parcel.zero_copy_optimization=0
  )

should do the trick.

StellarBot · 2024-11-10T00:47:49Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`7d9829e`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T00:36:01+00:00
Envfile
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-09T18:45:13.433264-06:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`7d9829e`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T00:36:01+00:00
Envfile
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-09T18:47:03.411026-06:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	---

Info

Property	Before	After
HPX Commit	`d27ac2e`	`7d9829e`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T00:36:01+00:00
Envfile
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-09T18:47:23.761508-06:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2024-11-10T04:22:44Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`31af988`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T04:13:47+00:00
Clustername	rostam	rostam
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-09T22:20:09.618092-06:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Envfile
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`31af988`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T04:13:47+00:00
Clustername	rostam	rostam
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-09T22:22:01.240836-06:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Envfile
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	---

Info

Property	Before	After
HPX Commit	`d27ac2e`	`31af988`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T04:13:47+00:00
Clustername	rostam	rostam
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-09T22:22:22.287788-06:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Envfile
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

codacy-production · 2024-11-10T13:13:18Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.41%	✅ 86.11%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`5356c52`)	234528	200611	85.54%
Head commit (`a312910`)	191533 (-42995)	163047 (-37564)	85.13% (-0.41%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6566)	108	93	86.11%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

StellarBot · 2024-11-10T17:22:35Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T17:12:29+00:00
HPX Commit	`d27ac2e`	`160bedc`
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-10T11:19:59.617213-06:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T17:12:29+00:00
HPX Commit	`d27ac2e`	`160bedc`
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-10T11:21:49.422544-06:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	-	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T17:12:29+00:00
HPX Commit	`d27ac2e`	`160bedc`
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-10T11:22:10.013304-06:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Clustername	rostam	rostam

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2024-11-10T21:27:35Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`9ed8d5c`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T21:19:43+00:00
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-10T15:24:58.579561-06:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Clustername	rostam	rostam

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`9ed8d5c`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T21:19:43+00:00
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-10T15:26:48.365468-06:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Clustername	rostam	rostam

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`9ed8d5c`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-10T21:19:43+00:00
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-10T15:27:08.803513-06:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Clustername	rostam	rostam

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2024-11-11T16:57:53Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`d3f6164`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-11T16:49:38+00:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-11T10:55:13.155092-06:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`d3f6164`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-11T16:49:38+00:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-11T10:57:04.425068-06:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	-	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	---

Info

Property	Before	After
HPX Commit	`d27ac2e`	`d3f6164`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-11T16:49:38+00:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-11T10:57:24.819328-06:00
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

StellarBot · 2024-11-11T20:53:15Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-11T20:40:35+00:00
HPX Commit	`d27ac2e`	`524da53`
Clustername	rostam	rostam
Envfile
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-11T14:50:09.185939-06:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-11T20:40:35+00:00
HPX Commit	`d27ac2e`	`524da53`
Clustername	rostam	rostam
Envfile
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-11T14:51:58.986229-06:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	-	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	---

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-11T20:40:35+00:00
HPX Commit	`d27ac2e`	`524da53`
Clustername	rostam	rostam
Envfile
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-11T14:52:19.738882-06:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

m-diers · 2024-11-13T11:41:59Z

@JiakunYan PP LCI now works here with the appropriate changes 👍

StellarBot · 2024-11-14T04:12:44Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`e28526a`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-14T04:02:30+00:00
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-13T22:10:08.768979-06:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Clustername	rostam	rostam

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`e28526a`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-14T04:02:30+00:00
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-13T22:12:00.164081-06:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Clustername	rostam	rostam

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	-	--
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	-	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`e28526a`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-14T04:02:30+00:00
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-13T22:12:20.692700-06:00
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile
Clustername	rostam	rostam

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

JiakunYan · 2024-11-14T15:57:56Z

@hkaiser The new test failed clang-16-debug mystically but worked fine for all other configurations. Do you have an instinct why?

From the test log, it seems the data transfer has been completed but the program was stuck in the finalization.

Update: I failed to reproduce this issue on Rostam with my own build.

StellarBot · 2024-11-15T05:22:47Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`adf6af8`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-15T05:12:24+00:00
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-14T23:20:09.270591-06:00
Envfile
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`adf6af8`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-15T05:12:24+00:00
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-14T23:21:59.107682-06:00
Envfile
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	--
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`adf6af8`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-15T05:12:24+00:00
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-14T23:22:19.593509-06:00
Envfile
Clustername	rostam	rostam
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.5/bin/clang++ 18.1.5

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

codacy-production · 2024-11-15T09:24:35Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.41%	✅ 86.11%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`b98428c`)	234528	200611	85.54%
Head commit (`8257eff`)	191533 (-42995)	163047 (-37564)	85.13% (-0.41%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6566)	108	93	86.11%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

StellarBot · 2024-11-17T03:27:22Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`bcc91c9`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-17T03:16:17+00:00
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-16T21:24:45.458517-06:00
Clustername	rostam	rostam
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Commit	`d27ac2e`	`bcc91c9`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-17T03:16:17+00:00
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-16T21:26:36.044569-06:00
Clustername	rostam	rostam
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	-	--
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	---

Info

Property	Before	After
HPX Commit	`d27ac2e`	`bcc91c9`
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-17T03:16:17+00:00
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-16T21:26:56.451093-06:00
Clustername	rostam	rostam
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

JiakunYan · 2024-11-17T15:45:10Z

@hkaiser Should I worry about the failed tests? Some (e.g. clang-13-debug) have compilation errors related to boost(?) and others (e.g. gcc-14-release) have some failed MPI tests.

Pansysk75 · 2024-11-17T16:23:47Z

@hkaiser Should I worry about the failed tests? Some (e.g. clang-13-debug) have compilation errors related to boost(?) and others (e.g. gcc-14-release) have some failed MPI tests.

That's my bad, we made some config change on rostam, so some Boost warnings will show up now.
Sorry about that, I'll fix it asap

StellarBot · 2024-11-18T15:33:46Z

Performance test report

HPX Performance

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR	PARALLEL_EXECUTOR	SCHEDULER_EXECUTOR
For Each	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-18T15:24:34+00:00
HPX Commit	`d27ac2e`	`78c1e48`
Clustername	rostam	rostam
Datetime	2024-03-18T09:18:04.949759-05:00	2024-11-18T09:30:41.277768-06:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile

Comparison

BENCHMARK	NO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-18T15:24:34+00:00
HPX Commit	`d27ac2e`	`78c1e48`
Clustername	rostam	rostam
Datetime	2024-03-18T09:19:53.062988-05:00	2024-11-18T09:32:32.419326-06:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile

Comparison

BENCHMARK	FORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATOR	PARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATOR	SCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add	--	--	--
Stream Benchmark - Scale	--	--	---
Stream Benchmark - Triad	--	--	--
Stream Benchmark - Copy	--	--	--

Info

Property	Before	After
HPX Datetime	2024-03-18T14:00:30+00:00	2024-11-18T15:24:34+00:00
HPX Commit	`d27ac2e`	`78c1e48`
Clustername	rostam	rostam
Datetime	2024-03-18T09:20:13.002391-05:00	2024-11-18T09:32:53.208993-06:00
Hostname	medusa08.rostam.cct.lsu.edu	medusa08.rostam.cct.lsu.edu
Compiler	/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1	/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile

Explanation of Symbols

Symbol	MEANING
=	No performance change (confidence interval within ±1%)
(=)	Probably no performance change (confidence interval within ±2%)
(+)/(-)	Very small performance improvement/degradation (≤1%)
+/-	Small performance improvement/degradation (≤5%)
++/--	Large performance improvement/degradation (≤10%)
+++/---	Very large performance improvement/degradation (>10%)
?	Probably no change, but quite large uncertainty (confidence interval with ±5%)
??	Unclear result, very large uncertainty (±10%)
???	Something unexpected…

JiakunYan requested a review from hkaiser as a code owner November 8, 2024 05:31

hkaiser added type: enhancement category: parcel transport type: compatibility issue labels Nov 8, 2024

hkaiser added this to the 1.11.0 milestone Nov 8, 2024

JiakunYan force-pushed the fix-bigmsg branch 2 times, most recently from 25d15b6 to a4b1932 Compare November 10, 2024 04:10

JiakunYan force-pushed the fix-bigmsg branch from b77b02e to a312910 Compare November 11, 2024 16:49

JiakunYan force-pushed the fix-bigmsg branch from a312910 to 032147f Compare November 11, 2024 20:40

JiakunYan force-pushed the fix-bigmsg branch from aca1bbc to 4389de1 Compare November 17, 2024 03:16

JiakunYan added 2 commits November 18, 2024 10:24

lci pp: fix messages larger than INT_MAX; add very_big_parcel_test

ab00d63

bump HPX_WITH_LCI_TAG to v1.7.8

8257eff

JiakunYan force-pushed the fix-bigmsg branch from 4389de1 to 8257eff Compare November 18, 2024 15:24

lci pp: fix messages larger than INT_MAX #6566

Are you sure you want to change the base?

lci pp: fix messages larger than INT_MAX #6566

Conversation

JiakunYan commented Nov 8, 2024 • edited Loading

StellarBot commented Nov 8, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

m-diers commented Nov 8, 2024

JiakunYan commented Nov 8, 2024

codacy-production bot commented Nov 8, 2024

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

hkaiser commented Nov 8, 2024

hkaiser commented Nov 8, 2024

JiakunYan commented Nov 8, 2024 • edited Loading

hkaiser commented Nov 8, 2024

StellarBot commented Nov 10, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Nov 10, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

codacy-production bot commented Nov 10, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

StellarBot commented Nov 10, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Nov 10, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Nov 11, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

Info

Explanation of Symbols

StellarBot commented Nov 11, 2024

HPX Performance

Comparison

Info

Comparison

Info

Comparison

JiakunYan commented Nov 8, 2024 •

edited

Loading

JiakunYan commented Nov 8, 2024 •

edited

Loading

codacy-production bot commented Nov 10, 2024 •

edited

Loading

JiakunYan commented Nov 14, 2024 •

edited

Loading

codacy-production bot commented Nov 15, 2024 •

edited

Loading