Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MACHINE: fix 'TF_A_MTD_START_OFFSET_NOR' with/without 'fw-update' feature [kirkstone, mickledore, scarthgap] #81

Open
wants to merge 1 commit into
base: kirkstone
Choose a base branch
from

Conversation

AdrianDC
Copy link

@AdrianDC AdrianDC commented Oct 6, 2024

Issue:

  • Before commit 71ade1b, 'TF_A_MTD_START_OFFSET_NOR' was '0x00080000'
  • After 'fwupdate support' was added, default value became '0x00100000', and 'fw-update' alternative value was the original '0x00080000' value

Context:

  • As visible in file 'FlashLayout_nor-sdcard_stm32mp157c-ev1_sample.tsv', with 'fw-update' enabled, the 'fip' primary partition offset on QSPI NOR moved from '0x00080000' to '0x00100000'

Origin:

  • Last year, without 'fw-update' enabled, I still had to create 'metadata1/2'
  • After commit 4bea958 fixed 'TF_A_ENABLE_METADATA', the generated layout is back to expected normal value, however 'TF_A_MTD_START_OFFSET_NOR' breaks, hence both issues revealed each other's issues

Workaround:

  • TF_A_MTD_START_OFFSET_NOR = "0x00080000"

…ture

Issue:
  - Before commit 71ade1b, 'TF_A_MTD_START_OFFSET_NOR' was '0x00080000'
  - After 'fwupdate support' was added, default value became '0x00100000',
    and 'fw-update' alternative value was the original '0x00080000' value

Context:
  - As visible in file 'FlashLayout_nor-sdcard_stm32mp157c-ev1_sample.tsv',
    with 'fw-update' enabled, the 'fip' primary partition offset on QSPI NOR
    moved from '0x00080000' to '0x00100000'

Origin:
  - Last year, without 'fw-update' enabled, I still had to create 'metadata1/2'
  - After commit 4bea958 fixed 'TF_A_ENABLE_METADATA', the generated layout
    is back to expected normal value, however 'TF_A_MTD_START_OFFSET_NOR' breaks,
    hence both issues revealed each other's issues

Workaround:
  - TF_A_MTD_START_OFFSET_NOR = "0x00080000"
---

Signed-off-by: Adrian DC <[email protected]>
@AdrianDC
Copy link
Author

AdrianDC commented Oct 6, 2024

Please apply the patch to :

  • kirkstone : Tested and used on a STM32MP157C using a Phytec SOM
  • mickledore : If possible
  • scarthgap : Next LTS

@BernardPuel
Copy link
Contributor

Hello Adrian, thanks for the patch. On the last release (V5.1.0) and next one, it managed another way so the issue is not present.
I will check with integration team for rapid integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants