CONF: MACHINE: use weak assignment for PREFERRED_PROVIDER #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By its nature, the PREFERRED_PROVIDER_* variables might be subject to change in upper layers with a line such as: PREFERRED_PROVIDER_virtual/kernel = "linux-foo" However adding the above line to local.conf to do a local experiment would not work as users might expect because the meta-st-stm32mp layer uses the '=' assignment, and local.conf is parsed earlier. Relying on parsing order is usually not a good idea, thus change all the PREFERRED_PROVIDER assignments in the machine files to using a weak assignment, like many other silicon vendor layers do. Using the ??= allows 2 further levels of overriding, e.g. by a board/SoM manufacturer and by a final integration layer. Signed-off-by: Luca Ceresoli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the ??= operator allows to override PREFERRED_PROVIDER in local.conf easily.
See the commit message for more details.