Eliminate @storis dependencies internalize configs #644
Conversation
…k of npm-run-all.
…ns within .config directory.
.eslintrc.js
Outdated
| }, | ||
| // allow trailing ASC and DESC on enumerations | ||
| { | ||
| selector: 'enumMember', |
There was a problem hiding this comment.
This rule is likely not relevant for this repo
.eslintrc.js
Outdated
| format: null, | ||
| }, | ||
| // GraphQL variables PascalCase | ||
| { |
There was a problem hiding this comment.
This rule is likely not relevant for this repo
.eslintrc.js
Outdated
| }, | ||
|
|
||
| { | ||
| files: ['**/*.types.ts', '**/types/*.ts', '**/*.schema.ts', '**/instances/**'], |
There was a problem hiding this comment.
I think the **/types/*.ts file override is relevant for this repo, but I don't believe any of the others are.
| extends: ['plugin:@typescript-eslint/recommended-requiring-type-checking'], | ||
| rules: { | ||
| // ban ts-comment except with description | ||
| '@typescript-eslint/ban-ts-comment': [ |
There was a problem hiding this comment.
I think we should make this:
// ban ts-comment except with description
'@typescript-eslint/ban-ts-comment': [
'error',
{
'ts-expect-error': { descriptionFormat: '^: ' },
'ts-ignore': true,
'ts-nocheck': true,
'ts-check': false,
},
],
There was a problem hiding this comment.
Good idea. Looking at all these rules has been great. Thank you.
.eslintrc.js
Outdated
| }, | ||
|
|
||
| { | ||
| files: ['**/index.[jt]s?(x)', '**/*.gql.[jt]s', '**/constants.ts'], |
There was a problem hiding this comment.
The gql suffix is definitely not needed as an override. I don't think the constants one is needed.
There was a problem hiding this comment.
removed gql and constants file matches.
tsconfig.json
Outdated
| }, | ||
| "include": [ | ||
| "src/**/*", // source folder | ||
| "scripts/**/*", // scripts folder | ||
| "test/**/*", // test helpers | ||
| "./*.js", // root javascript files | ||
| "./.*.js" // root javascript config files | ||
| ] | ||
| ], | ||
| "ts-node": { |
There was a problem hiding this comment.
This isn't relevant to this repo
There was a problem hiding this comment.
done. removed ts-node config
shawnmcknight
deleted the
eliminate-@storis-dependencies-internalize-configs
branch
This PR removes the two storis dependencies
@storis/eslint-configand@storis/tsconfig. Those repositories are no longer being maintained, so their configs will be internalized.This PR also updates the
eslint-config-prettierplugin.There was an attempt made to upgrade eslint to v9 as well, but there are plugins that are yet to support v9 of eslint. They have been documented in a tracker issue - #646