Skip to content

Commit

Permalink
fix(SHS-5905): Get contextual links working (finally) for Social Medi…
Browse files Browse the repository at this point in the history
…a block
  • Loading branch information
codechefmarc committed Nov 11, 2024
1 parent 9f6d7fd commit a75486f
Show file tree
Hide file tree
Showing 5 changed files with 107 additions and 57 deletions.
86 changes: 43 additions & 43 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions config/default/user.role.site_manager.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ dependencies:
- filter.format.basic_html
- filter.format.minimal_html
- filter.format.minimal_html_with_styles
- media.type.embeddable
- media.type.file
- media.type.image
- media.type.video
Expand Down Expand Up @@ -42,7 +43,6 @@ dependencies:
- file
- filter
- help
- hs_blocks
- hs_entities
- hs_page_reports
- media
Expand Down Expand Up @@ -76,7 +76,9 @@ permissions:
- 'administer main menu items'
- 'administer nodes'
- 'administer users'
- 'assign author role'
- 'assign contributor role'
- 'assign intranet_viewer role'
- 'assign site_manager role'
- 'create embeddable media'
- 'create file media'
Expand Down Expand Up @@ -186,7 +188,7 @@ permissions:
- 'edit terms in hs_person_staff_type'
- 'edit terms in hs_person_student_type'
- 'edit terms in hs_publication_type'
- 'import hs_courses migration'
- 'import hs_capx migration'
- 'import hs_events_importer migration'
- 'manipulate entityqueues'
- 'mark as hidden in editoria11y'
Expand All @@ -195,6 +197,7 @@ permissions:
- 'publish any content'
- 'publish editable content'
- 'rabbit hole bypass node'
- 'rabbit hole bypass taxonomy_term'
- 'revert hs_basic_page revisions'
- 'revert hs_course revisions'
- 'revert hs_event revisions'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ hs_blocks.block_move_down:
# data-dialog-renderer: off_canvas

hs_blocks.social_media_block:
title: Edit Social Media Block
route_name: entity.block.edit_form
title: 'Edit Social Media block'
route_name: 'entity.block.edit_form'
group: 'social_media_block'
6 changes: 5 additions & 1 deletion docroot/modules/humsci/hs_blocks/hs_blocks.module
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ function hs_blocks_theme($existing, $type, $theme, $path) {
],
'hs_blocks_social_media' => [
'template' => 'block--social-media',
'variables' => ['icon_size' => NULL, 'layout' => NULL, 'links' => []],
'variables' => [
'icon_size' => NULL,
'layout' => NULL,
'links' => [],
],
],
];
}
Expand Down
Loading

0 comments on commit a75486f

Please sign in to comment.