Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5657: "Add media" is inconsistent #1680

Closed
wants to merge 1 commit into from

Conversation

cienvaras
Copy link
Collaborator

@cienvaras cienvaras commented Nov 6, 2024

NOT READY FOR REVIEW

Summary

  • Temporary PR to test update to stanford_media module

Need Review By (Date)

['10/30', 'asap', etc.]

Urgency

medium

Steps to Test

  1. Login into the tugboat test site
  2. Visit the Add Media page
  3. Confirm that the "Bulk Upload" link includes the list of media types that can be added in bulk
Screenshot 2024-11-06 at 5 36 48 PM

PR Checklist

@cienvaras cienvaras self-assigned this Nov 6, 2024
@ahughes3 ahughes3 temporarily deployed to Tugboat November 6, 2024 23:08 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 6, 2024 23:30 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 6, 2024 23:30 Destroyed
@cienvaras
Copy link
Collaborator Author

cienvaras commented Nov 6, 2024

@ahughes3 Created this temporary PR for testing the functionality in tugboat. For some reason I'm not able to login into any of the test sites, I think that there's probably a tugboat configuration issue. I'll check tomorrow to see what's going on.

Some considerations:

  • I created a PR against [https://github.com/SU-SWS/stanford_media](SWS stanford_media) repo with the change.
  • The latest version of stanford_media is 11.1.2 which requires Drupal 10.3. That means that my change will probably have to wait until the H&S platform is updated to that Drupal version to see the changes in production.

@cienvaras
Copy link
Collaborator Author

@ahughes3 Just saw your message in Slack with the new tugboat credentials. Confirmed it works, just updated the testing instructions with direct links to the pages.

Base automatically changed from 11.5.1-release to develop November 13, 2024 15:35
@ahughes3 ahughes3 requested a review from pookmish November 26, 2024 19:41
@pookmish
Copy link
Member

pookmish commented Dec 2, 2024

No longer needed since SU-SWS/stanford_media#158 has been merged and released in 11.1.3

@pookmish pookmish closed this Dec 2, 2024
@pookmish pookmish deleted the shs-5657--add-media-inconsistent branch December 2, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants