Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Lando config to work with PHP 8.3 #1684

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Update Lando config to work with PHP 8.3 #1684

merged 1 commit into from
Nov 14, 2024
+2 −2

Conversation

codechefmarc
Copy link
Collaborator

READY FOR REVIEW

Summary

Updates the default Lando config file to work with the latest 11.5.2 release branch changes with PHP 8.3 and latest Composer.

Need Review By (Date)

2024-11-18

Urgency

High

Steps to Test

  1. Use this branch (branched off of 11.5.2-release)
  2. Follow the Lando steps here: https://github.com/SU-HSDO/suhumsci/tree/develop/lando
  3. Verify that local builds work correctly and there are no errors

PR Checklist

@ahughes3 ahughes3 temporarily deployed to Tugboat November 14, 2024 00:14 Destroyed
@codechefmarc codechefmarc requested a review from joegl November 14, 2024 00:14
@codechefmarc
Copy link
Collaborator Author

I added Joe just for visibility, Andres can test and if passed, Joe can merge into 11.5.2-release.

@codechefmarc codechefmarc marked this pull request as ready for review November 14, 2024 00:19
cienvaras
cienvaras approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codechefmarc works as expected, thanks!

joegl
joegl approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@joegl joegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marc!

@joegl joegl merged commit 7221e97 into 11.5.2-release Nov 14, 2024
15 of 16 checks passed
@joegl joegl deleted the lando-changes-11.5.2 branch November 14, 2024 16:05
@joegl joegl changed the title Update Lando config for 11.5.2 release Update Lando config to work with PHP 8.3 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegl joegl joegl approved these changes

@cienvaras cienvaras cienvaras approved these changes

Assignees

@codechefmarc codechefmarc

Labels
Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codechefmarc @cienvaras @joegl @ahughes3