Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5912: Improve link styles preview #1688

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

cienvaras
Copy link
Collaborator

@cienvaras cienvaras commented Nov 21, 2024

READY FOR REVIEW

Summary

  • Change the layout of the CKEditor "Styles" dropdown, to show only one item per row and improve legibility of the preview.

Need Review By (Date)

12/04

Urgency

medium

Steps to Test

  1. Create a Flexible Page
  2. In the text area component, add some text, headings, links, etc.
  3. Try to apply some custom styles using the "Style" dropdown menu. Confirm that you see only one element per row and that the previews are legible. Confirm that you can apply and remove styles as expected.
Screenshot 2024-11-20 at 6 09 05 PM

PR Checklist


@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 00:14 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 02:59 Destroyed
@ahughes3
Copy link
Collaborator

ahughes3 commented Nov 21, 2024

@cienvaras @joegl Tugboat is failing with this error:

Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run composer update or composer update <package name>.
Your lock file does not contain a compatible set of packages. Please run composer update.

Problem 1
- Root composer.json requires php >=8.3 but your php version (8.2.13) does not satisfy that requirement.

image

https://dashboard.tugboatqa.com/log/673eae1df67b7935927c2d64

@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 03:50 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 15:49 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 15:49 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 15:50 Destroyed
@joegl
Copy link
Contributor

joegl commented Nov 21, 2024

@ahughes3 It looks like it was caching the previous docker image which was on PHP 8.2. I rebuilt the preview without a base and it is working now.

Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ahughes3 ahughes3 requested a review from pookmish November 26, 2024 19:40
@ahughes3 ahughes3 assigned pookmish and unassigned ahughes3 Nov 26, 2024
Copy link
Member

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix 👍

@pookmish pookmish merged commit 64b6bf1 into 11.6.1-release Nov 26, 2024
24 of 25 checks passed
@pookmish pookmish deleted the shs-5912--improve-link-styles-preview branch November 26, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants