Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5912: Improve link styles preview #1688

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

cienvaras
Copy link
Collaborator

@cienvaras cienvaras commented Nov 21, 2024

READY FOR REVIEW

Summary

  • Change the layout of the CKEditor "Styles" dropdown, to show only one item per row and improve legibility of the preview.

Need Review By (Date)

12/04

Urgency

medium

Steps to Test

  1. Create a Flexible Page
  2. In the text area component, add some text, headings, links, etc.
  3. Try to apply some custom styles using the "Style" dropdown menu. Confirm that you see only one element per row and that the previews are legible. Confirm that you can apply and remove styles as expected.
Screenshot 2024-11-20 at 6 09 05 PM

PR Checklist


@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 00:14 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 02:59 Destroyed
@ahughes3
Copy link
Collaborator

ahughes3 commented Nov 21, 2024

@cienvaras @joegl Tugboat is failing with this error:

Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run composer update or composer update <package name>.
Your lock file does not contain a compatible set of packages. Please run composer update.

Problem 1
- Root composer.json requires php >=8.3 but your php version (8.2.13) does not satisfy that requirement.

image

https://dashboard.tugboatqa.com/log/673eae1df67b7935927c2d64

@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 03:50 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 15:49 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 15:49 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat November 21, 2024 15:50 Destroyed
@joegl
Copy link
Contributor

joegl commented Nov 21, 2024

@ahughes3 It looks like it was caching the previous docker image which was on PHP 8.2. I rebuilt the preview without a base and it is working now.

Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ahughes3 ahughes3 requested a review from pookmish November 26, 2024 19:40
@ahughes3 ahughes3 assigned pookmish and unassigned ahughes3 Nov 26, 2024
Copy link
Member

@pookmish pookmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix 👍

@pookmish pookmish merged commit 64b6bf1 into 11.6.1-release Nov 26, 2024
24 of 25 checks passed
@pookmish pookmish deleted the shs-5912--improve-link-styles-preview branch November 26, 2024 23:31
pookmish added a commit that referenced this pull request Jan 8, 2025
* 11.6.1

* Update lock file.

* SHS-5911: Add indicator of 3rd level shortcut menu (#1681)

* SHS-5911: Add indicator of 3rd level shortcut menu.

* fix(shs-5912): change layout of ckeditor styles dropdown list (#1688)

Co-authored-by: joegl <[email protected]>

* SHS:5892: Site managers can perform actions on user accounts that don't make sense with SSO (#1682)

* feat(shs-5892): remove actions from people view

* feat(shs-5892): remove elements from used edit form

* fix(shs-5892): fix issues in user edit form alter

* fix(shs-5892): remove delete actions only for non admin users

* Updated dependencies

* fix(shs-5911): use absolute path for image url to prevent error when drupal aggregates image (#1693)

* HSD8-1700: Increase Tugboat Max Allowed Packet size to 512MB. (#1695)

Co-authored-by: Seth Hendrick <[email protected]>

* SHS-5808: Uninstall Webform module (#1625)

* SHS-5905: Rework social media footer (#1662)

* feat(SHS-5905): Recreate social media block as a custom block plugin

* feat(SHS-5905): Add composer.lock

* feat(SHS-5905): Enable multivalue form element module

* feat(SHS-5905): Add update hook for permissions change

* fix(SHS-5905): Fix error for default config and add cache context for user

* fix(SHS-5905): Contextual menu still not rendering on Tugboat for non-admins

* fix(SHS-5905): Fix attached library for contextual menu

* fix(SHS-5909): Strict checking of the array seemed to fix the contextual links on local

* fix(SHS-5905): Remove strict checking

* fix(SHS-5905): Remove old permissions before adding social media block permissions

* fix(SHS-5905): Linting fixes

* chore(SHS-5905): WIP TEST ONLY - see if removing the code block in the profile works on tugboat

* fix(SHS-5905): Fix contextual menu for non-admins

* feat(SHS-5905): Remove permission update hook and add dependency on one in profile

* feat(shs-5906): icon logic, templates and styles for social media footer block (#1673)

* chore(SHS-5905): Temp remove code to test other contextual menus

* feat(SHS-5905): Add custom contextual link

* fix(SHS-5905): Get contextual links working (finally) for Social Media block

* fix(shs-5905): fixes in social media block

* fix(shs-5905): replace multivalue_form_element with custom version in social media block

* fix(shs-5905): remove multivalue_form_element module

* fix(shs-5905): update social media block links help text

* fix(shs-5905): social media footer block fixes

---------

Co-authored-by: Andrés Díaz Soto <[email protected]>

* Update hook to delete webform submissions

* SHS-5958: Bug: Inconsistent "Add Above" feature (#1692)

* fix(SHS-5958): Fix issue with paragraphs features to allow add buttons on non gin/claro themes

* feat(SHS-5958): Add config and update hook to allow add paragraphs in between

* refactor(SHS-5958): Change how we are updating the add in between to config

* test(SHS-5958): Update test to refelect new buttons

* test(SHS-5958): Update testPostCard test for new add in between buttons

* test(SHS-5958): Update other tests for new add in between buttons

* test(SHS-5958): Add a wait in test to make sure JS add in between buttons load

* test(SHS-5958): Fix photo album test - photo album can come before or after text component, making tests work sometimes but not all the time

* fix(shs-5958): fix video embed test

* fix(shs-5958): fix private page tests

* fix(shs-5958): fix video embed test

* fix(shs-5958): fix private page tests

* fix(shs-5958): fixes in tests

* fix(shs-5958): fix private page tests

* fix(shs-5958): fix private page tests

* chore(SHS-5958): Remove unnecessary layout builder config

* chore(SHS-5958): Revert hidden layout builder layout

* chore(SHS-5958): Revert composer.lock to 11.6.1 version

---------

Co-authored-by: Andrés Díaz Soto <[email protected]>

* Removed unintended underscore in update hook name

* fixup update function name

* HSD8-1707: Removed edit button from default people view to resolve button display to anonymous users. (#1701)

* SHS-5904: Add new "log out" block to existing sites (#1696)

* HSD8-1664: Updated PR template (#1685)

* Updated PR template.

* Updated sanitiztion line.

* dropped ready for review title. added review tasks heading.

---------

Co-authored-by: joegl <[email protected]>

* Revoke any webform permissions before uninstall module

* Removed assert_options from settings files

* HSD8-1702: delete mediterraneanstudies

---------

Co-authored-by: Github Actions <[email protected]>
Co-authored-by: joegl <[email protected]>
Co-authored-by: Mariana Núñez <[email protected]>
Co-authored-by: Andrés Díaz Soto <[email protected]>
Co-authored-by: Mike Decker <[email protected]>
Co-authored-by: Seth <[email protected]>
Co-authored-by: Seth Hendrick <[email protected]>
Co-authored-by: Marc Berger <[email protected]>
Co-authored-by: Joe Gilliland-Lloyd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants