Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5958: Bug: Inconsistent "Add Above" feature #1692

Merged
merged 22 commits into from
Dec 17, 2024

Conversation

codechefmarc
Copy link
Collaborator

@codechefmarc codechefmarc commented Dec 4, 2024

READY FOR REVIEW

Summary

  • Adds "Add between" buttons to paragraphs on Flexible Pages and Private Pages.

Need Review By (Date)

2024-12-04

Urgency

medium

Steps to Test

  1. Login to the site
  2. Add a new Flexible Page or Private Page
  3. Verify that there are "+ Add" buttons for paragraphs

Screenshot 2024-12-04 at 11 42 51 AM

  1. Add a paragraph
  2. Verify that there is also an "+Add" button that gets added when hovering over a paragraph to add in between
  3. Edit an existing Flexible Page or Private Page
  4. Verify that the "+Add" buttons show up there as well

PR Checklist


@ahughes3 ahughes3 temporarily deployed to Tugboat December 4, 2024 01:24 Destroyed
@codechefmarc codechefmarc self-assigned this Dec 4, 2024
@ahughes3 ahughes3 temporarily deployed to Tugboat December 4, 2024 19:11 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat December 4, 2024 20:06 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat December 4, 2024 20:17 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat December 4, 2024 20:42 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat December 4, 2024 21:21 Destroyed
… after text component, making tests work sometimes but not all the time
@ahughes3 ahughes3 temporarily deployed to Tugboat December 4, 2024 21:48 Destroyed
@codechefmarc codechefmarc marked this pull request as ready for review December 4, 2024 21:57
@codechefmarc
Copy link
Collaborator Author

@cienvaras - This is ready for review. Note - I had to update some of the tests to click on the new add in-between buttons so those worked. Though I'm still getting some of those reoccurring test errors for unrelated things. I think I fixed the testPhotoAlbum one - it was because the photo album could be above or below the text area and sometimes it would fail it it was above it as the test was specifically calling item 1 (second paragraph). I changed it to use an XPath selector to look specifically for stanford_gallery but that test didn't run in the last test run so not sure. I'm out of hours for this week, so I can continue next week on these tests if needed. Thanks!

@ahughes3 ahughes3 temporarily deployed to Tugboat December 5, 2024 01:49 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat December 5, 2024 02:07 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat December 5, 2024 18:44 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat December 5, 2024 19:00 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat December 5, 2024 21:34 Destroyed
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codechefmarc We missed a couple of changes that need to be reverted, please see inline comments. Thanks!

@ahughes3 ahughes3 temporarily deployed to Tugboat December 11, 2024 00:42 Destroyed
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahughes3 This is ready for you to review.

@cienvaras cienvaras requested a review from ahughes3 December 13, 2024 22:27
@cienvaras cienvaras assigned ahughes3 and unassigned codechefmarc Dec 13, 2024
@ahughes3 ahughes3 temporarily deployed to Tugboat December 13, 2024 22:29 Destroyed
Copy link
Collaborator

@ahughes3 ahughes3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ahughes3 ahughes3 assigned sethprime and pookmish and unassigned ahughes3 and sethprime Dec 17, 2024
@pookmish pookmish merged commit 28633c9 into 11.6.1-release Dec 17, 2024
17 checks passed
@pookmish pookmish deleted the SHS-5958--fix-add-above branch December 17, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants