-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS-5958: Bug: Inconsistent "Add Above" feature #1692
Conversation
… after text component, making tests work sometimes but not all the time
@cienvaras - This is ready for review. Note - I had to update some of the tests to click on the new add in-between buttons so those worked. Though I'm still getting some of those reoccurring test errors for unrelated things. I think I fixed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codechefmarc We missed a couple of changes that need to be reverted, please see inline comments. Thanks!
config/default/core.entity_form_display.node.hs_basic_page.default.yml
Outdated
Show resolved
Hide resolved
config/default/core.entity_form_display.node.hs_private_page.default.yml
Outdated
Show resolved
Hide resolved
…-5958--fix-add-above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ahughes3 This is ready for you to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
READY FOR REVIEW
Summary
Need Review By (Date)
2024-12-04
Urgency
medium
Steps to Test
PR Checklist