SHS-5944: Uninstall Honeypot module #1698
Open
+23
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalin-
reviewed
Dec 16, 2024
There was a problem hiding this comment.
@codechefmarc
I took a look at a tugboat site, and the module/config is all gone (as expected). I was hoping to be able to look at a log somewhere and see the Deleted @config messages, but I couldn't find that in either Tugboat or Github Actions.
Maybe I'm not the best person to review this :-)
cienvaras
requested changes
Dec 17, 2024
There was a problem hiding this comment.
@codechefmarc Works as expected. There's one thing you missed though: please remove the module dependency in docroot/profiles/humsci/su_humsci_profile/su_humsci_profile.info.yml.
|
@cienvaras - Good catch. Removed. |
cienvaras
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
@codechefmarc LGTM, thanks for the fix!
@ahughes3 Ready for you to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Need Review By (Date)
2024-12-18
Urgency
low
Steps to Test
/admin/modulesPR Checklist