SHS-6000: Stanford login font link changes #1705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Fix Stanford login font link
Urgency
medium
Note
In the
hs_adminmodule there's a preprocess function in line 131 that check if there's a SAML form and adds a classsimplesamlphp-auth-login-link, but it's not working. Something in thestanford_samlauthis working different or I'm not sure, couldn't find what is causing that preprocess to not add that class. However, using thesamlauth-logindoesn't seem to be a problem.Steps to Test
/user/loginStanford Loginlooks like thisPR Checklist