-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHS-5981: Site Dashboard: Active Site Editors #1721
SHS-5981: Site Dashboard: Active Site Editors #1721
Conversation
…ithub.com:SU-HSDO/suhumsci into shs-5981--dashboard-active-site-editors-block
…ithub.com:SU-HSDO/suhumsci into shs-5981--dashboard-active-site-editors-block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar Looks good, however the "View all active site editors" don't match the AC, please check the ticket and adjust accordingly.
Also, the previous version of this PR had some CSS. Things look good on the dashboard, so I just wanted to confirm if it's not needed anymore or if you removed it by accident.
@cienvaras This is ready for review again! https://pr1721-owc6uhbjbocdblzr55v0je8nvbwiunyi.tugboatqa.com/admin/dashboard And yeah, there were some CSS styles, but I figured it out that since those styles were going to be the same for this kind of blocks (with tables), I moved those styles to the other PR and make it more general. I don't think the styles will change a lot for each block, or that's not what I understood in the design Tori provided in the other ticket of design implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariannuar LGTM!
@ahughes3 Ready for you.
…ithub.com:SU-HSDO/suhumsci into shs-5981--dashboard-active-site-editors-block
Merging into #1719 to make it easier to review the dashboard base design. |
b2e83da
into
shs-6035--dashboard-initial-design-implementation
Summary
Add an Active Site Editors block for the Dashboard. This ticket depends on #1719
Need Review By (Date)
01/24
Urgency
high
Steps to Test
/admin/structure/dashboard
or https://pr1721-owc6uhbjbocdblzr55v0je8nvbwiunyi.tugboatqa.com/admin/dashboardActive Site Editors
and add it/admin/dashboard
or the preview of the dashboardActive Site Editors
block looks like thisReview Tasks
Backend / Functional Validation
Code
snake_case
and notcamelCase
?Code security
General