Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5981: Site Dashboard: Active Site Editors #1721

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Jan 17, 2025

Summary

Add an Active Site Editors block for the Dashboard. This ticket depends on #1719

Need Review By (Date)

01/24

Urgency

high

Steps to Test

  1. Go to /admin/structure/dashboard or https://pr1721-owc6uhbjbocdblzr55v0je8nvbwiunyi.tugboatqa.com/admin/dashboard
  2. Create a dashboard if there isn't an existing one
  3. Enable it
  4. Edit the layout
  5. Create a section
  6. Add a block, confirm that now you can add one that is called Active Site Editors and add it
  7. Now go to /admin/dashboard or the preview of the dashboard
  8. Confirm the Active Site Editors block looks like this

Screenshot 2025-01-17 at 12 39 11 PM

  1. The block should show the username, roles and the last access

Review Tasks

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Are PHP functions and variables in snake_case and not camelCase?
  • Does Drupal code follow Drupal Coding Standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided?

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

@ahughes3 ahughes3 temporarily deployed to Tugboat January 17, 2025 18:39 Destroyed
@mariannuar mariannuar self-assigned this Jan 17, 2025
…ithub.com:SU-HSDO/suhumsci into shs-5981--dashboard-active-site-editors-block
@ahughes3 ahughes3 temporarily deployed to Tugboat January 17, 2025 21:03 Destroyed
…ithub.com:SU-HSDO/suhumsci into shs-5981--dashboard-active-site-editors-block
@ahughes3 ahughes3 temporarily deployed to Tugboat January 21, 2025 19:28 Destroyed
@mariannuar mariannuar requested a review from cienvaras January 21, 2025 20:42
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar Looks good, however the "View all active site editors" don't match the AC, please check the ticket and adjust accordingly.

Also, the previous version of this PR had some CSS. Things look good on the dashboard, so I just wanted to confirm if it's not needed anymore or if you removed it by accident.

@ahughes3 ahughes3 temporarily deployed to Tugboat January 24, 2025 16:32 Destroyed
@mariannuar
Copy link
Collaborator Author

mariannuar commented Jan 24, 2025

@cienvaras This is ready for review again! https://pr1721-owc6uhbjbocdblzr55v0je8nvbwiunyi.tugboatqa.com/admin/dashboard

And yeah, there were some CSS styles, but I figured it out that since those styles were going to be the same for this kind of blocks (with tables), I moved those styles to the other PR and make it more general. I don't think the styles will change a lot for each block, or that's not what I understood in the design Tori provided in the other ticket of design implementation.

@mariannuar mariannuar requested a review from cienvaras January 24, 2025 16:43
Copy link
Collaborator

@cienvaras cienvaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariannuar LGTM!

@ahughes3 Ready for you.

@cienvaras cienvaras requested a review from ahughes3 January 27, 2025 15:02
@cienvaras cienvaras assigned ahughes3 and unassigned mariannuar Jan 27, 2025
…ithub.com:SU-HSDO/suhumsci into shs-5981--dashboard-active-site-editors-block
@ahughes3 ahughes3 temporarily deployed to Tugboat February 3, 2025 15:34 Destroyed
@cienvaras
Copy link
Collaborator

Merging into #1719 to make it easier to review the dashboard base design.

@cienvaras cienvaras merged commit b2e83da into shs-6035--dashboard-initial-design-implementation Feb 3, 2025
17 checks passed
@cienvaras cienvaras deleted the shs-5981--dashboard-active-site-editors-block branch February 3, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants