Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.x 1.x soe 3004 footer update #4

Merged
merged 2 commits into from
May 24, 2018
Merged

Conversation

minorwm
Copy link
Contributor

@minorwm minorwm commented May 24, 2018

READY FOR REVIEW

Summary

This adds the updated footer markup from the stanford_framework theme update.

Needed By (Date)

  • Sprint end

Criticality

  • Needed by COB Friday May 25, 2018

Steps to Test

Affects

  • SoE (School of Engineering website)

Associated Issues and/or People

Related JIRA ticket(s)

https://stanfordits.atlassian.net/browse/SOE-3004

Related PRs

More Information

Folks to notify

@boznik

See Also

@minorwm minorwm self-assigned this May 24, 2018
@minorwm minorwm requested a review from boznik May 24, 2018 18:38
@boznik boznik assigned boznik and unassigned minorwm May 24, 2018
Copy link
Contributor

@boznik boznik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected with most recent stanford_framework

@boznik boznik merged commit 893c629 into 7.x-1.x May 24, 2018
@boznik boznik deleted the 7.x-1.x-SOE-3004-footer-update branch May 24, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants