SOE-3584: Adding print--html.tpl.php for the print 2.2 upgrade #7
Conversation
| @@ -137,6 +137,10 @@ function stanford_soe_regions_theme() { | |||
| 'template' => 'templates/digital-magazine-page', | |||
| 'render element' => 'page' | |||
| ), | |||
| 'print__html' => array( | |||
There was a problem hiding this comment.
This solution looks good but I have a couple of questions to understand the issue and resolution path.
Why have you added this theme hook here? Where did it go in print 2.2? Was this ever an option?
What I want to know is why it worked before and why you chose to fix this issue by adding it to this module.
There was a problem hiding this comment.
@sherakama I added it there because I didn't want to put it in the theme and the regions module is where the digital magazine template is located, so it seemed proper.
As far as why it worked before, I'm not 100% sure on that, but it had something to do with this: https://www.drupal.org/node/2276407
I figured I could get it working in 2.2 and then get a template to load correctly.
READY FOR REVIEW
Summary
Needed By (Date)
Urgency
Steps to Test
drush cc allprint/magazine/article/anne-kiremidjian-cities-built-endure-disasterAssociated Issues and/or People
See Also