Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra quote #927

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Removed extra quote #927

merged 1 commit into from
Oct 5, 2023

Conversation

pookmish
Copy link
Contributor

@pookmish pookmish commented Oct 5, 2023

No description provided.

Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG - thanks @pookmish

@yvonnetangsu yvonnetangsu added the patch Releases a patch tag label Oct 5, 2023
@yvonnetangsu
Copy link
Member

@sherakama Any idea why the preview generation failed - is it related to the recent v6 package updates?

@yvonnetangsu
Copy link
Member

Merging this in as I don't think this is related to Decanter itself, but more likely due to the preview site build. This PR change is pretty safe.

@yvonnetangsu yvonnetangsu merged commit 5766ca0 into master Oct 5, 2023
0 of 3 checks passed
@yvonnetangsu yvonnetangsu deleted the pookmish-patch-3 branch October 5, 2023 20:21
@jenbreese
Copy link
Contributor

Boy you are fast. Looks good to me too. Thanks for finding and fixing.

@pookmish
Copy link
Contributor Author

pookmish commented Oct 5, 2023

Thanks 😄

@sherakama
Copy link
Member

@sherakama Any idea why the preview generation failed - is it related to the recent v6 package updates?

Probably this: af5267f

@sherakama
Copy link
Member

and this: 45d58ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases a patch tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants