New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D8CORE-6976: removed italics from the quote style #930

Merged

yvonnetangsu merged 1 commit into master from D8CORE-6976--removed-italics

Oct 19, 2023

Contributor

jenbreese commented Oct 19, 2023

READY FOR REVIEW

Summary

Removed the italics style from the quote-text mixin. This was done for a11y reasons.

Needed By (Date)

as time allows

Urgency

normal

Steps to Test

Checkout this branch.
Use the quote-text mixin.
Verify it is not coming with italics.

Affected Projects or Products

Sites using Decanter and the Stanford Basic theme

Associated Issues and/or People

See Also

PR Checklist


          D8CORE-6976: removed italics from the quote style

77f64a3

jenbreese requested review from sherakama and yvonnetangsu

October 19, 2023 20:46

jenbreese assigned sherakama and yvonnetangsu

yvonnetangsu added the patch label

yvonnetangsu approved these changes

View reviewed changes

Member

yvonnetangsu left a comment

GTG thanks @jenbreese ! 😄

yvonnetangsu merged commit 5b80b3f into master

3 checks passed

yvonnetangsu deleted the D8CORE-6976--removed-italics branch

October 19, 2023 21:00

Member

yvonnetangsu commented Oct 19, 2023

New release is out @jenbreese 😄
https://github.com/SU-SWS/decanter/releases/tag/6.3.2

Contributor Author

jenbreese commented Oct 19, 2023

@yvonnetangsu Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch