Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TW to 3.3.5 and dependencies to latest; remove tailwind-lineclamp for real #939

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Nov 6, 2023

READY FOR REVIEW

Summary

  • Just update TW to 3.3.5, and remove tailwind line-clamp plugin for realz

Needed By (Date)

  • When does this need to be merged by?

Urgency

  • How critical is this PR?

Steps to Test

  1. Look at the code and the preview

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@github-actions github-actions bot added the size/s label Nov 6, 2023
@@ -31,19 +31,18 @@
"dependencies": {
"@tailwindcss/aspect-ratio": "^0.4.2",
"@tailwindcss/forms": "^0.5.3",
"@tailwindcss/line-clamp": "^0.4.4",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I approved Mike's PR to remove this plugin since it's included in core TW since TW v3.3.3
https://github.com/tailwindlabs/tailwindcss-line-clamp/
As of Tailwind CSS v3.3 the line-clamp utilities are now included in the framework by default and this plugin is no longer required.

Somehow this sneaked back in probably when I merged some changes previously 😬

@yvonnetangsu yvonnetangsu added the patch Releases a patch tag label Nov 6, 2023
@yvonnetangsu
Copy link
Member Author

I suppose the autorelease process works just as before? I added the patch tag 👀

@sherakama
Copy link
Member

I suppose the autorelease process works just as before? I added the patch tag 👀

In theory, it should.

@yvonnetangsu
Copy link
Member Author

Thanks, @sherakama !

@yvonnetangsu yvonnetangsu merged commit 3ff6cf2 into main Nov 7, 2023
4 checks passed
@yvonnetangsu yvonnetangsu deleted the update-tw branch November 7, 2023 02:09
@yvonnetangsu
Copy link
Member Author

Looks like the autorelease still works as expected 🎉

@sherakama
Copy link
Member

Whew, snuck in a fix just in time.

@yvonnetangsu
Copy link
Member Author

Whew, snuck in a fix just in time.

Whew - just saw that 🤣 Thanks @sherakama !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases a patch tag size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants