Merge pull request #95 from SU-SWS/release-8.2.4

"8.x-2.x > 8.2.4
SU-SWS · Aug 7, 2020 · 6a58cbf · 6a58cbf
2 parents a5e290e + d434692
commit 6a58cbf
Show file tree

Hide file tree

Showing 9 changed files with 40 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,15 @@
 # Stanford News
 
+8.x-2.4
+--------------------------------------------------------------------------------
+_Release Date: 2020-08-07_
+
+- D8CORE-2432: changed the font size for the load more button (#94) (02656d3)
+- D8CORE-2132: adding a wrapper div to address issue with SOE subtheme (#93) (0d1eae9)
+- Merge pull request #92 from SU-SWS/D8CORE-1938-focus (dbda2bf)
+- D8CORE-1938: on vertical cards, move focus indicator from link/image to entire card (cf9f32a)
+- Removed views_taxonomy_term_name_depth thats not used (#91) (6a1373d)
+
 8.x-2.3
 --------------------------------------------------------------------------------
 _Release Date: 2020-07-13_

diff --git a/composer.json b/composer.json
@@ -92,7 +92,6 @@
         "drupal/taxonomy_menu": "dev-3.x#c0892fa9b428ceb784876554c9b80f49d72a246f",
         "drupal/views_block_filter_block": "^1.0",
         "drupal/views_infinite_scroll": "^1.6",
-        "drupal/views_taxonomy_term_name_depth": "^6.0",
         "su-sws/jumpstart_ui": "^8.1.0",
         "su-sws/stanford_text_editor": "^8.1.0"
     },

diff --git a/dist/css/news-list-item.css b/dist/css/news-list-item.css
diff --git a/dist/css/news-vertical-teaser.css b/dist/css/news-vertical-teaser.css
diff --git a/lib/scss/components/news-list-item/_list-item.scss b/lib/scss/components/news-list-item/_list-item.scss
@@ -106,6 +106,17 @@
   }
 }
 
+.stanford-news--list {
+  .js-pager__items {
+    .pager__item {
+
+      .button {
+        font-size: 2.8rem;
+      }
+    }
+  }
+}
+
 .su-news-external {
   .su-news-list__item {
     a {

diff --git a/lib/scss/components/news-vertical-teaser/_news-vertical-teaser.scss b/lib/scss/components/news-vertical-teaser/_news-vertical-teaser.scss
@@ -114,6 +114,10 @@
           text-decoration: underline;
         }
       }
+
+      &:focus {
+        outline: none;
+      }
     }
 
     // Action title link.
@@ -162,6 +166,11 @@
         }
       }
     }
+
+    // Put the focus on the whole card
+    &:focus-within {
+      outline: -webkit-focus-ring-color auto 1px;
+    }
   }
 }
 

diff --git a/stanford_news.info.yml b/stanford_news.info.yml
@@ -3,7 +3,7 @@ type: module
 description: 'Stanford news items and views.'
 core_version_requirement: ^8.8 || ^9
 package: Stanford
-version: 8.x-2.3
+version: 8.x-2.4
 dependencies:
   - allowed_formats:allowed_formats
   - auto_entitylabel:auto_entitylabel
@@ -42,7 +42,6 @@ dependencies:
   - ui_patterns:ui_patterns_views
   - views_block_filter_block:views_block_filter_block
   - views_infinite_scroll:views_infinite_scroll
-  - views_taxonomy_term_name_depth:views_taxonomy_term_name_depth
 
 component-libraries:
     news: { paths: [templates/components] }
diff --git a/templates/components/news-vertical-teaser/news-vertical-teaser.twig b/templates/components/news-vertical-teaser/news-vertical-teaser.twig
@@ -47,9 +47,11 @@
       {{- news_vertical_teaser_image -}}
     </div>
   </figure>
-  <h2 class="su-link su-card__link {{ news_url_link_type }}">
-    {{- news_vertical_teaser_headline -}}
-  </h2>
+  <div class="su-news-header">
+    <h2 class="su-link su-card__link {{ news_url_link_type }}">
+      {{- news_vertical_teaser_headline -}}
+    </h2>
+  </div>
   {%- if news_url is not empty -%}
     </a>
   {%- endif -%}

diff --git a/tests/codeception/acceptance/NewsNodeCest.php b/tests/codeception/acceptance/NewsNodeCest.php
@@ -16,11 +16,11 @@ public function testNewsNode(\AcceptanceTester $I) {
 
     $I->amOnPage('/news');
     $I->canSee('This is a headline', 'h2');
-    $I->canSee(date('F j, Y'));
+    $I->canSee(date('F d, Y'));
 
     $I->click('Foo');
     $I->canSee('This is a headline', 'h2');
-    $I->canSee(date('F j, Y'));
+    $I->canSee(date('F d, Y'));
 
     $I->logInWithRole('authenticated');
     $I->amOnPage('/news');