Fixed cap API parameter string (#141)

SU-SWS · Apr 22, 2021 · 06cdedd · 06cdedd
1 parent 9d36d10
commit 06cdedd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/...les/stanford_person_importer/config/install/migrate_plus.migration.su_stanford_person.yml b/...les/stanford_person_importer/config/install/migrate_plus.migration.su_stanford_person.yml
@@ -9,6 +9,7 @@ migration_tags: {  }
 migration_group: su_stanford_person
 label: 'Stanford Person Importer'
 source:
+  plugin: url
   constants:
     status: 1
     type: stanford_person

diff --git a/modules/stanford_person_importer/src/Cap.php b/modules/stanford_person_importer/src/Cap.php
@@ -181,7 +181,7 @@ public function getSunetUrl($sunetids) {
     // Cap API default to 10 results. Send the argument to collect more if
     // there are more sunets to get results for.
     if ($count > 10) {
-      $url .= "?ps=$count";
+      $url .= "&ps=$count";
     }
     return $url;
   }

diff --git a/modules/stanford_person_importer/tests/src/Unit/CapTest.php b/modules/stanford_person_importer/tests/src/Unit/CapTest.php
@@ -172,7 +172,7 @@ public function testUrls() {
 
     $sunets = implode(',', array_fill(0, 20, 'foo'));
     $url = $this->service->getSunetUrl($sunets);
-    $this->assertEquals("https://cap.stanford.edu/cap-api/api/profiles/v1?uids=$sunets?ps=20", $url);
+    $this->assertEquals("https://cap.stanford.edu/cap-api/api/profiles/v1?uids=$sunets&ps=20", $url);
   }
 
   /**