8.1.18

- Update SHS module
- Updated views_infinite_scroll module (#157)

.circleci/config.yml

@@ -47,21 +47,6 @@ back_to_dev: &back_to_dev
           composer global require SU-SWS/stanford-caravan:dev-8.x-2.x
           ~/.composer/vendor/bin/sws-caravan back-to-dev ${CIRCLE_TAG} ${CIRCLE_WORKING_DIRECTORY}
 
-d8_codeception: &d8_codeception
-  <<: *defaults
-  steps:
-    - checkout:
-        path: /var/www/test
-    - run:
-        name: Run Codeception Tests
-        command: |
-          composer global require SU-SWS/stanford-caravan:dev-8.x-1.x
-          ~/.composer/vendor/bin/sws-caravan codeception /var/www/html --extension-dir=/var/www/test
-    - store_test_results:
-        path: /var/www/html/artifacts/behat
-    - store_artifacts:
-        path: /var/www/html/artifacts
-
 d9_codeception: &d9_codeception
   <<: *defaults
   steps:
@@ -83,8 +68,6 @@ jobs:
     <<: *code_coverage
   run-back-to-dev:
     <<: *back_to_dev
-  run-d8-codeception:
-    <<: *d8_codeception
   run-d9-codeception:
     <<: *d9_codeception
 
@@ -104,7 +87,6 @@ workflows:
   tests:
     jobs:
       - run-coverage
-      - run-d8-codeception
       - run-d9-codeception
   # Re-test every sunday in case this code becomes stale.
   sundays:

CHANGELOG.md

@@ -1,6 +1,15 @@
 # Stanford News
 
 
+8.x-1.18
+--------------------------------------------------------------------------------
+_Release Date: 2022-03-17_
+
+- Update SHS module
+- Updated views_infinite_scroll module (#157)
+- Removed D8 Tests
+
+
 8.x-1.17
 --------------------------------------------------------------------------------
 _Release Date: 2021-11-19_

composer.json

@@ -87,16 +87,17 @@
         "drupal/paragraphs": "^1.11",
         "drupal/pathauto": "^1.8",
         "drupal/real_aes": "^2.3",
-        "drupal/shs": "^1.0@alpha",
+        "drupal/shs": "^2.0@RC",
         "drupal/taxonomy_menu": "dev-3.x",
         "drupal/view_unpublished": "^1.0",
         "drupal/views_block_filter_block": "^1.0",
         "drupal/views_contextual_filters_or": "^1.1",
-        "drupal/views_infinite_scroll": "^1.6",
+        "drupal/views_infinite_scroll": "^2.0",
         "sainsburys/guzzle-oauth2-plugin": "^3.0",
         "su-sws/jumpstart_ui": "^8.1",
         "su-sws/stanford_migrate": "^8.1",
-        "su-sws/stanford_text_editor": "^8.1"
+        "su-sws/stanford_text_editor": "^8.1",
+        "su-sws/drupal-patches": "^8.0"
     },
     "extra": {
         "enable-patching": true,

modules/stanford_person_importer/stanford_person_importer.info.yml

@@ -3,7 +3,7 @@ type: module
 description: 'Migration support for importing of profile information from stanford.edu.'
 core_version_requirement: '^8.8 || ^9'
 package: Stanford
-version: 8.x-1.17
+version: 8.x-1.18
 dependencies:
   - 'config_pages:config_pages'
   - 'drupal:migrate'

stanford_person.info.yml

@@ -3,7 +3,7 @@ type: module
 description: 'A person bio and supporting information content type'
 core_version_requirement: ^8 || ^9
 package: Stanford
-version: 8.x-1.17
+version: 8.x-1.18
 dependencies:
   - allowed_formats:allowed_formats
   - auto_entitylabel:auto_entitylabel

tests/codeception/acceptance/StanfordPersonCest.php

@@ -16,7 +16,7 @@ public function testPersonNode(AcceptanceTester $I) {
    */
   public function testVocabularyTermsExists(AcceptanceTester $I) {
     $I->logInWithRole('administrator');
-    $I->amOnPage("/admin/structure/taxonomy/manage/stanford_person_types/overview");
+    $I->amOnPage('/admin/structure/taxonomy/manage/stanford_person_types/overview');
     $I->canSeeResponseCodeIs(200);
   }
 
@@ -28,25 +28,25 @@ public function testViewPagesExist(AcceptanceTester $I) {
 
     $I->createEntity([
       'vid' => 'stanford_person_types',
-      'name' => "Student",
-      'description' => "Student",
+      'name' => 'Student',
+      'description' => 'Student',
     ], 'taxonomy_term');
 
     $I->createEntity([
       'vid' => 'stanford_person_types',
-      'name' => "Staff",
-      'description' => "Staff",
+      'name' => 'Staff',
+      'description' => 'Staff',
     ], 'taxonomy_term');
 
     $I->runDrush('cache-rebuild');
 
-    $I->amOnPage("/people");
+    $I->amOnPage('/people');
     $I->canSeeResponseCodeIs(200);
-    $I->see("Filter By Person Type");
+    $I->see('Filter By Person Type');
 
-    $I->amOnPage("/people/staff");
+    $I->amOnPage('/people/staff');
     $I->canSeeResponseCodeIs(200);
-    $I->see("Filter By Person Type");
+    $I->see('Filter By Person Type');
   }
 
   /**
@@ -56,32 +56,31 @@ public function testViewPagesExist(AcceptanceTester $I) {
   public function testCreatePerson(AcceptanceTester $I) {
     $I->createEntity([
       'type' => 'stanford_person',
-      'su_person_first_name' => "John",
-      'su_person_last_name' => "Wick",
+      'su_person_first_name' => 'John',
+      'su_person_last_name' => 'Wick',
       'su_person_short_title' => 'Finisher of contracts',
     ]);
     $I->runDrush('cache-rebuild');
-    $I->amOnPage("/person/john-wick");
-    $I->see("John Wick");
-    $I->see("Finisher of contracts");
-    $I->amOnPage("/people");
-    $I->see("John Wick");
+    $I->amOnPage('/person/john-wick');
+    $I->see('John Wick');
+    $I->see('Finisher of contracts');
+    $I->amOnPage('/people');
+    $I->see('John Wick');
   }
 
   /**
    * Test for the default image.
    */
   public function testDefaultImage(AcceptanceTester $I) {
-    $I->logInWithRole("administrator");
+    $I->logInWithRole('administrator');
     $I->amOnPage('/node/add/stanford_person');
-    $I->fillField("First Name", "John");
-    $I->fillField("Last Name", "Wayne");
-    $I->fillField("Short Title", "Cowboy");
-    $I->click("Save");
-    $I->amOnPage("/person/john-wayne");
-    $I->runDrush('cache-rebuild');
-    $I->see("John Wayne");
-    $I->see("Cowboy");
+    $I->fillField('First Name', 'John');
+    $I->fillField('Last Name', 'Wayne');
+    $I->fillField('Short Title', 'Cowboy');
+    $I->click('Save');
+    $I->canSeeInCurrentUrl('/person/john-wayne');
+    $I->see('John Wayne', 'h1');
+    $I->see('Cowboy');
     $I->seeElement('.field--name-su-person-photo');
   }