8.1.13

- Fixed cap API parameter string (#141)
SU-SWS · May 7, 2021 · 744595f · 744595f
2 parents 2f30463 + a053ba7
commit 744595f
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Stanford News
 
+8.x-1.13
+--------------------------------------------------------------------------------
+_Release Date: 2021-05-07_
+
+- Fixed cap API parameter string (#141) (06cdedd)
+
 8.x-1.12
 --------------------------------------------------------------------------------
 _Release Date: 2021-03-05_

diff --git a/...les/stanford_person_importer/config/install/migrate_plus.migration.su_stanford_person.yml b/...les/stanford_person_importer/config/install/migrate_plus.migration.su_stanford_person.yml
@@ -9,6 +9,7 @@ migration_tags: {  }
 migration_group: su_stanford_person
 label: 'Stanford Person Importer'
 source:
+  plugin: url
   constants:
     status: 1
     type: stanford_person

diff --git a/modules/stanford_person_importer/src/Cap.php b/modules/stanford_person_importer/src/Cap.php
@@ -181,7 +181,7 @@ public function getSunetUrl($sunetids) {
     // Cap API default to 10 results. Send the argument to collect more if
     // there are more sunets to get results for.
     if ($count > 10) {
-      $url .= "?ps=$count";
+      $url .= "&ps=$count";
     }
     return $url;
   }

diff --git a/modules/stanford_person_importer/stanford_person_importer.info.yml b/modules/stanford_person_importer/stanford_person_importer.info.yml
@@ -3,7 +3,7 @@ type: module
 description: 'Migration support for importing of profile information from stanford.edu.'
 core_version_requirement: '^8.8 || ^9'
 package: Stanford
-version: 8.x-1.12
+version: 8.x-1.13
 dependencies:
   - 'config_pages:config_pages'
   - 'drupal:migrate'

diff --git a/modules/stanford_person_importer/tests/src/Unit/CapTest.php b/modules/stanford_person_importer/tests/src/Unit/CapTest.php
@@ -172,7 +172,7 @@ public function testUrls() {
 
     $sunets = implode(',', array_fill(0, 20, 'foo'));
     $url = $this->service->getSunetUrl($sunets);
-    $this->assertEquals("https://cap.stanford.edu/cap-api/api/profiles/v1?uids=$sunets?ps=20", $url);
+    $this->assertEquals("https://cap.stanford.edu/cap-api/api/profiles/v1?uids=$sunets&ps=20", $url);
   }
 
   /**

diff --git a/stanford_person.info.yml b/stanford_person.info.yml
@@ -3,7 +3,7 @@ type: module
 description: 'A person bio and supporting information content type'
 core_version_requirement: ^8 || ^9
 package: Stanford
-version: 8.x-1.12
+version: 8.x-1.13
 dependencies:
   - allowed_formats:allowed_formats
   - auto_entitylabel:auto_entitylabel