Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify templates_branch on a primary group, to use that #366

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

indy-independence
Copy link
Member

branch when generating config for devices in that primary group

branch when generating config for devices in that primary group
…ings before first refresh of templates for ex
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 68.29268% with 26 lines in your changes missing coverage. Please review.

Project coverage is 64.46%. Comparing base (189f1cc) to head (5b5b02f).
Report is 12 commits behind head on develop.

Files Patch % Lines
src/cnaas_nms/db/git_worktrees.py 52.50% 19 Missing ⚠️
src/cnaas_nms/db/git.py 16.66% 5 Missing ⚠️
src/cnaas_nms/db/settings.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #366      +/-   ##
===========================================
+ Coverage    64.43%   64.46%   +0.02%     
===========================================
  Files           74       75       +1     
  Lines         8096     8166      +70     
===========================================
+ Hits          5217     5264      +47     
- Misses        2879     2902      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Aug 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots

See analysis details on SonarCloud

@indy-independence indy-independence merged commit b7f5c02 into develop Oct 7, 2024
6 of 7 checks passed
@indy-independence indy-independence deleted the feature.primary_group_templates_branch branch October 7, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant