Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security zone backend #450

Merged
merged 36 commits into from
Jun 17, 2024
Merged

Security zone backend #450

merged 36 commits into from
Jun 17, 2024

Conversation

johanlundberg
Copy link
Member

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johanlundberg
Copy link
Member Author

johanlundberg commented May 30, 2024 •
edited
Loading

Quality Gate Failed

10.3% Duplication on New Code (required ≤ 3%)

eidas and bankid is till more or less the same app, so this can be ignored.

@johanlundberg johanlundberg marked this pull request as ready for review June 17, 2024 06:48
helylle
helylle reviewed Jun 17, 2024
View reviewed changes
src/eduid/webapp/common/authn/utils.py Outdated Show resolved Hide resolved
src/eduid/webapp/security/views/webauthn.py Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@helylle helylle merged commit d124178 into main Jun 17, 2024
8 of 9 checks passed
@helylle helylle deleted the ft-new_auth branch June 17, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helylle helylle helylle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johanlundberg @helylle @fredrikt