add more linting rules and fixes #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per the documentation, a micro-optimization but more readable code
|
helylle
commented
Sep 19, 2024
Comment on lines
+303
to
+304
| resources = [{"id": str(this.scim_id), "displayName": this.display_name} for this in groups] | ||
|
|
There was a problem hiding this comment.
For readability 'this' should probably be replaced with 'group'
helylle
commented
Sep 19, 2024
| @@ -58,7 +58,7 @@ def is_valid_password(password: str, user_info: Sequence[str], min_entropy: int, | |||
| # Check password complexity with zxcvbn | |||
| result = zxcvbn(password, user_inputs=user_info) | |||
| _guesses = result.get("guesses", 1) | |||
| _pw_entropy = math.log(_guesses, 2) | |||
| _pw_entropy = math.log2(_guesses) | |||
There was a problem hiding this comment.
log2(x) is usually more accurate than log(x, 2) according to
https://docs.python.org/3/library/math.html#math.log2
(Added in python 3.3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few more rules and small fixes
Largest patch is list comprehension replacing list manipulation inside for loops