Enable updating nin #716
Merged
Enable updating nin #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if reference nin is the same as locked nin let verification through and replace the locked nin with the new verified nin
helylle
commented
Nov 19, 2024
helylle
commented
Nov 28, 2024
Comment on lines
+197
to
+201
| attributes = { | ||
| "$set": { | ||
| "identities": [{"identity_type": IdentityType.NIN.value, "number": "200102031234", "verified": True}] | ||
| } | ||
| } |
There was a problem hiding this comment.
nins have previously been replaced
helylle
commented
Nov 28, 2024
Comment on lines
+224
to
+226
| "identities": [ | ||
| {"identity_type": IdentityType.NIN.value, "number": locked_nin.number, "verified": True} | ||
| ], # hubba-bubba |
There was a problem hiding this comment.
nins have previously been replaced
helylle
commented
Nov 28, 2024
Comment on lines
202
to
207
| new_attributes = check_locked_identity(self.amdb, user_id, attributes, "test") | ||
|
|
||
| # check_locked_identity should create a locked_identity so add it to the expected attributes | ||
| locked_nin = NinIdentity(number="200102031234", created_by="test", is_verified=True) | ||
| locked_identities = LockedIdentityList(elements=[locked_nin]) | ||
| attributes["$set"]["locked_identity"] = locked_identities.to_list_of_dicts() |
There was a problem hiding this comment.
check_locked_attributes used to modify (and return) attributes, i.e. the same entity, so even if it did not add locked_identity the test was always true as attributes and new_attributes were the same dict
helylle
commented
Nov 28, 2024
Comment on lines
229
to
231
| new_attributes = check_locked_identity(self.amdb, user_id, attributes, "test") | ||
|
|
||
| locked_identities = LockedIdentityList(elements=[locked_nin]) | ||
| attributes["$set"]["locked_identity"] = locked_identities.to_list_of_dicts() | ||
|
|
||
| # user has locked_identity that is the same as the verified identity so only identities should be set | ||
| self.assertDictEqual(attributes, new_attributes) |
There was a problem hiding this comment.
The same comment as for test above
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable updating NIN and locked NIN if the new NIN has a reference to the currently locked NIN
Use case is changing of national identity number or groinf from coordination number to national identoty number