Hide settings that cant be changed

SUNET · Sep 5, 2024 · 2485fd1 · 2485fd1
1 parent f23cf20
commit 2485fd1
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/mfazones/lib/Controller/MfazonesController.php b/mfazones/lib/Controller/MfazonesController.php
@@ -122,11 +122,18 @@ public function get(): JSONResponse
       $type = $this->castObjectType($node->getType());
       $result = $this->tagMapper->haveTag($node->getId(), $type, $tagId);
 
+      try {
+        $mfa_on_parent = $this->utils->nodeOrParentHasTag($node->getParent());
+      } catch (NotFoundException) {
+        $mfa_on_parent = false;
+      }
+
       return new JSONResponse(
         array(
           'status' => $result,
           'mfa_passed' => $this->isMfaVerified(),
-          'has_access' => $this->hasAccess($source)
+          'has_access' => $this->hasAccess($source),
+          'mfa_on_parent' => $mfa_on_parent
         )
       );
     } catch (\Exception $e) {

diff --git a/mfazones/src/views/MFATab.vue b/mfazones/src/views/MFATab.vue
@@ -21,8 +21,9 @@
       <label for="enable-2fa-button">This is a mfazone that has been shared with you, so you can not change any settings
         for it.</label><br><br>
     </div>
-    <div id="not-owner" style="--icon-size:36px;" hidden>
-      <label for="enable-2fa-button">This is a mfazone that has been shared with you, so you can not change any settings for it.</label><br><br>
+    <div id="not-top" style="--icon-size:36px;" hidden>
+      <label for="enable-2fa-button">This is a mfazone that has been set further up in the file tree, you must go there
+        to change settings for it. But take this ⚔, it is dangerous to go alone.</label><br><br>
     </div>
   </NcActions>
 </template>
@@ -92,15 +93,22 @@ export default {
       var needMFA = document.getElementById('need-mfa');
       var haveMFA = document.getElementById('have-mfa');
       var notOwner = document.getElementById('not-owner');
+      var notTop = document.getElementById('not-top');
       needMFA.hidden = true;
       notOwner.hidden = true;
       haveMFA.hidden = true;
+      notTop.hidden = true;
       let mfa_passed = state.mfa_passed;
       let status = state.status;
       let has_access = state.has_access;
+      let mfa_on_parent = state.mfa_on_parent;
       if (mfa_passed) {
         if (has_access) {
-          haveMFA.hidden = false;
+          if (mfa_on_parent) {
+            notTop.hidden = false;
+          } else {
+            haveMFA.hidden = false;
+          }
         } else {
           notOwner.hidden = false;
         }