Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-image-crop from 10.1.8 to 11.0.1 in /client #1107

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 4, 2023

Bumps react-image-crop from 10.1.8 to 11.0.1.

Release notes

Sourced from react-image-crop's releases.

11.0.1

  • Add overflow: hidden to the image wrapper so that scaling and rotating doesn't overflow the component since removing overflow: hidden from the component itself

11.0.0

Not a breaking change for most users, but the way crop shadow is done is significantly different, and hopefully solves two problems while not introducing others 🙏:

  • fix: crop shadow on circular crop not working in Safari
  • improve: component no longer has overflow: hidden applied, which makes some kinds of customization easier. Also the crop handles now overflow the container instead of getting cut off:
  • Breaking change for users of SASS variables:

Variables are now done with CSS Variables. They are as follows:

:root {
  --rc-drag-handle-size: 12px;
  --rc-drag-handle-mobile-size: 24px;
  --rc-drag-handle-bg-colour: rgba(0, 0, 0, 0.2);
  --rc-drag-bar-size: 6px; /* The invisible grip size of the crop selection edges */
  --rc-border-color: rgba(255, 255, 255, 0.7);
  --rc-focus-color: #0088ff;
}
  • Fix use of input in a renderSelectionAddon #570
Commits
  • ad6ee0f Add overflow: hidden to __child-wrapper
  • 10573ae No pointer events on circ crop outer border
  • a0cc2a1 Different technique for crop shadow with no overflow hidden, fixes #530. Swit...
  • 2e7f176 fix mouse down event in add-on components (#570)
  • fa441b2 Update README.md
  • 547d32e Remove link to 9.1.1 tag
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52fae11) 99.12% compared to head (dec6b7a) 99.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1107   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files          90       90           
  Lines        7427     7427           
=======================================
  Hits         7362     7362           
  Misses         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Bumps [react-image-crop](https://github.com/DominicTobias/react-image-crop) from 10.1.8 to 11.0.1.
- [Release notes](https://github.com/DominicTobias/react-image-crop/releases)
- [Commits](dominictobias/react-image-crop@10.1.8...11.0.1)

---
updated-dependencies:
- dependency-name: react-image-crop
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/client/react-image-crop-11.0.1 branch from f42a013 to dec6b7a Compare December 8, 2023 10:54
@oharsta
Copy link
Collaborator

oharsta commented Dec 8, 2023

@baszoetekouw Do not merge this PR. It is not backwards compatible and breaks the component. I'll need to look at the changes and changed styling.

@baszoetekouw baszoetekouw merged commit 740fb5f into main Dec 19, 2023
15 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/client/react-image-crop-11.0.1 branch December 19, 2023 09:52
@baszoetekouw baszoetekouw restored the dependabot/npm_and_yarn/client/react-image-crop-11.0.1 branch December 19, 2023 12:18
@baszoetekouw baszoetekouw deleted the dependabot/npm_and_yarn/client/react-image-crop-11.0.1 branch January 10, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants