Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Test replace finds #47

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Draft: Test replace finds #47

wants to merge 6 commits into from

Conversation

mrvanes
Copy link
Contributor

@mrvanes mrvanes commented Jul 7, 2022

We moeten nog wel even goed dubbelchecken of alles nog is zoals het was ;)
~6m30 -> 4m8 is ongeveer 35% snelheidswinst

# time python -m cProfile -s cumtime plsc_ordered.py plsc.yml &> plsc_ordered.log

real    4m8.500s
user    0m14.300s
sys     0m0.853s

# time python -m cProfile -s cumtime plsc_flat.py plsc.yml &> plsc_flat.log

real    3m50.528s
user    0m12.623s
sys     0m1.668s

@mrvanes mrvanes changed the title Draft: Test replace finds Test replace finds Jul 7, 2022
@mrvanes mrvanes requested a review from baszoetekouw November 22, 2022 07:56
@mrvanes mrvanes changed the title Test replace finds Draft: Test replace finds Nov 22, 2022
@baszoetekouw baszoetekouw marked this pull request as draft November 22, 2022 12:58
@mrvanes mrvanes linked an issue Dec 9, 2022 that may be closed by this pull request
@baszoetekouw
Copy link
Member

The approach is probably ok, but I'm hesitant to merge this now, as plsc is getting more and more spaghettiesk. And rewriting/refactoring plsc is risky because we lack unittests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimalizaties waarschijnlijk nodig
2 participants