Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for barclamp_keystone #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmnelemane
Copy link

Added basic feature tests for keystone with

Access to keystone resource lists(eg: services, projects, users, hosts etc) through openstackclient
create/delete users and project using openstackclient command line interface
Added new openstack.rb function to the cct library to include command for "openstack host list"

@mmnelemane mmnelemane changed the title Add tests for barclamp_keystone [WIP]Add tests for barclamp_keystone Sep 17, 2015
control_node.rpm_q(client_package)
end

Then(/^I can create a new project "([^"]*)" on the cloud$/) do |project_name|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all (or most of) the OpenStack CLI code is already available upstream. See i.e. https://github.com/openstack/python-openstackclient/blob/master/functional/tests/identity/v2/test_project.py . Why are not using that code (and extend it if needed)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add checks for SSL,PKI and Tokens instead of using openstack client tests here ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client uses SSL and PKI tokens if that's what was deployed. AFAIR we agreed to not check things like "Feature A was enabled, now check if Feature A is really enabled". That will be done with crowbar_batch. Or am I missunderstanding your question?

@vuntz vuntz added the wip label Sep 23, 2015
@dirkmueller
Copy link

@mmnelemane can you rebase this?

@bmwiedemann
Copy link
Member

https://ci.suse.de/job/openstack-mkcloud/15243/ failed in cct

Ambiguous match of "the chef role "rabbitmq-server" exists on admin node":
features/step_definitions/barclamp_keystone/keystone_steps.rb:1:in `/^the chef role "([^"]*)" exists on admin node$/'
features/step_definitions/barclamps/barclamp_steps.rb:1:in `/^the chef role "([^"]*)" exists on admin node$/'

@mmnelemane
Copy link
Author

@bmwiedemann: corrected that.

@mmnelemane mmnelemane removed the wip label Jan 22, 2016
@mmnelemane mmnelemane changed the title [WIP]Add tests for barclamp_keystone Add tests for barclamp_keystone Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants