Use ssh gateway only if cct is run outside of admin node #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -173,9 +171,10 @@ def detect_timeout opts={} | |||
| timeout.to_i | |||
| end | |||
|
|
|||
| def validate_options | |||
| def validate_options *options_to_skip | |||
There was a problem hiding this comment.
Style/MethodDefParentheses: Use def with parentheses when there are parameters. (https://github.com/bbatsov/ruby-style-guide#method-parens)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @bmwiedemann for pointing at the overhead with accessing the
control_nodethrough ssh-gateway even when the testsuite is run on admin node. This change makes cct to run faster and easier to debug in CI/mkcloud. Using gateway is still available if cct is run outside of admin node.Will be backported to cloud6 branches.