Migration tests for KVM/Xen #79
Conversation
|
|
||
| @kvm | ||
| Scenario: Test KVM migration | ||
| Given At least 2 KVM Hypervisors are available |
There was a problem hiding this comment.
Let's make it more explicit we expect having 2 nodes, e.g. At least 2 nodes with KVM hypervisors
| And I migrate KVM instance | ||
| Then I expect the instance will run on different host | ||
| And will be in state "ACTIVE" | ||
| And I turn off the instance(so it will not use resources) |
There was a problem hiding this comment.
Parenthesis should be avoided in feature files, usually it works by adding short sentence e.g. to save resources.
| And I turn off the instance(so it will not use resources) | ||
|
|
||
| @xen | ||
| Scenario: Test Xen migrationnd I turn off the instance(so it will not use resources) |
There was a problem hiding this comment.
All following after word migration doesn't seem to belong there
| And I migrate Xen instance | ||
| Then I expect the instance will run on different host | ||
| And will be in state "ACTIVE" | ||
| And I turn off the instance(so it will not use resources) |
| @@ -0,0 +1,15 @@ | |||
| Given(/^At least (\d+) Compute nodes must be enabled$/) do |arg1| | |||
There was a problem hiding this comment.
Usually you want to give some real name to parameters in blocks to recognize later what kind of object you are expecting, in this case it would be e.g. number_of_nodes instead of arg1
| def delete_old_instances(server_id) | ||
| puts("old instance #{server_id } found - deleting") | ||
| control_node.exec!("openstack server delete #{server_id}") | ||
| end |
There was a problem hiding this comment.
Would be better to move this method into step helpers https://github.com/SUSE-Cloud/cct/blob/master/features/support/step_helpers.rb , then you don't need to define it again in the context of the next step.
| s.name == @instance_name and delete_old_instances(s.id) | ||
| end | ||
| # create a new instance | ||
| new_instance = control_node.exec!("openstack server create -f shell --flavor m1.smaller --image jeos --security-group default -c id #{@instance_name}") |
There was a problem hiding this comment.
This line is a bit too long, splitting it into several lines usually works:
command = "openstack server create -f shell --flavor m1.smaller --image jeos " +
"--security-group default -c id #{@instance_name}"| end | ||
| # create a new instance | ||
| new_instance = control_node.exec!("openstack server create -f shell --flavor m1.smaller --image jeos --security-group default -c id #{@instance_name}") | ||
| @new_instance_id = new_instance.output[4, 36] |
There was a problem hiding this comment.
Is this needed? The output only should contain the server id (looking at -c id from the command above).
There was a problem hiding this comment.
it shows id="6499c426-1c57-4516-934e-c5e7460f675a"
I didn't dig deeper in exec! but if there is a option to get it directly it shouldn't be needed.
Maybe sth like 'new_instance.id'
There was a problem hiding this comment.
ok so -f value returns only ID.. that could simplify it.
There was a problem hiding this comment.
At the end .split used since -f value will return \n which broke other commands. ok
| s.name == @instance_name and delete_old_instances(s.id) | ||
| end | ||
| # create a new instance | ||
| new_instance = control_node.exec!("openstack server create -f shell --flavor m1.smaller --image jeos --security-group default -c id #{@instance_name}") |
| break | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
This step has exact same implementation as the one for Xen, it should work for both to parametrize the hypervisor name in the step line in the feature file, e.g. When(/^I migrate "KVM" instance$/) do .
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-24157-xmbv2w/.rubocop.yml
Use the following configuration instead:
Rails:
Enabled: true
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-12973-pr7ymh/.rubocop.yml
Use the following configuration instead:
Rails:
Enabled: true
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-24164-10axlp2/.rubocop.yml
Use the following configuration instead:
Rails:
Enabled: true
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-31178-192cjtk/.rubocop.yml
Use the following configuration instead:
Rails:
Enabled: true
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-12503-1f6gc0n/.rubocop.yml
Use the following configuration instead:
Rails:
Enabled: true
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-31164-7bho99/.rubocop.yml
Use the following configuration instead:
Rails:
Enabled: true
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-...
Error: obsolete parameter RunRailsCops (for AllCops) found in /tmp/d20170531-31150-17894s0/.rubocop.yml
Use the following configuration instead:
Rails:
Enabled: true
Add migration tests for KVM and XEN into CCT. Plus add 2 openstack commands as well.
Kvm migration can be called directly with mkcloud environment variable cct_tests="feature:migration:kvm"
Xen migration can be called directly with mkcloud environment variable cct_tests="feature:migration:xen"