Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the go version to three components #2144

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Limit the go version to three components #2144

merged 1 commit into from
Dec 20, 2024

Conversation

dcermak
Copy link
Collaborator

@dcermak dcermak commented Dec 18, 2024

The go-openssl variant has/had a four component version which confuses the heck out of the go ecosystem. Therefore @jfkw patched go-openssl to no longer output the fourth component, but now we have a mismatch between the output go-openssl version and the go-openssl rpm package version.

By setting the replace_using_package_version service to parse the patch version, we hopefully eliminate this discrepancy in the GOLANG_VERSION environment variable.

@dcermak
Limit the go version to three components
cddb682 
The go-openssl variant has/had a four component version which confuses the heck
out of the go ecosystem. Therefore jfkw patched go-openssl to no longer output
the fourth component, but now we have a mismatch between the output go-openssl
version and the go-openssl rpm package version.

By setting the replace_using_package_version service to parse the patch version,
we hopefully eliminate this discrepancy in the `GOLANG_VERSION` environment
variable.
dcermak pushed a commit that referenced this pull request Dec 18, 2024
Test build for #2144
b5acc22
dcermak pushed a commit that referenced this pull request Dec 18, 2024
Test build for #2144
ee2ea32
dcermak pushed a commit that referenced this pull request Dec 18, 2024
Test build for #2144
d49d1a0
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-2144
Changes pushed to branch 6-2144 as commit b5acc22d83d1b36032ca7d3671b9376dce537a49
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2144 for x86_64: current state: published
Build results:

package name status build log
golang-oldstable-image ⛔ excluded live log
golang-oldstable-openssl-image ⛔ excluded live log
golang-stable-image ⛔ excluded live log
golang-stable-openssl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2144 for aarch64: current state: published
Build results:

package name status build log
golang-oldstable-image ⛔ excluded live log
golang-oldstable-openssl-image ⛔ excluded live log
golang-stable-image ⛔ excluded live log
golang-stable-openssl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2144 for s390x: current state: published
Build results:

package name status build log
golang-oldstable-image ⛔ excluded live log
golang-oldstable-openssl-image ⛔ excluded live log
golang-stable-image ⛔ excluded live log
golang-stable-openssl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-2144 for ppc64le: current state: published
Build results:

package name status build log
golang-oldstable-image ⛔ excluded live log
golang-oldstable-openssl-image ⛔ excluded live log
golang-stable-image ⛔ excluded live log
golang-stable-openssl-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2144 for x86_64: current state: published
Build results:

package name status build log
golang-oldstable-image ✅ succeeded live log
golang-oldstable-openssl-image ✅ succeeded live log
golang-stable-image ✅ succeeded live log
golang-stable-openssl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2144 for aarch64: current state: published
Build results:

package name status build log
golang-oldstable-image ✅ succeeded live log
golang-oldstable-openssl-image ✅ succeeded live log
golang-stable-image ✅ succeeded live log
golang-stable-openssl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2144 for s390x: current state: published
Build results:

package name status build log
golang-oldstable-image ✅ succeeded live log
golang-oldstable-openssl-image ✅ succeeded live log
golang-stable-image ✅ succeeded live log
golang-stable-openssl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-2144 for ppc64le: current state: published
Build results:

package name status build log
golang-oldstable-image ✅ succeeded live log
golang-oldstable-openssl-image ✅ succeeded live log
golang-stable-image ✅ succeeded live log
golang-stable-openssl-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2144/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-2144/containerfile/bci/golang:latest

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2144
Changes pushed to branch Tumbleweed-2144 as commit d49d1a0317e76483f37b3c81914ff17b4c796f88
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2144 for x86_64: current state: published
Build results:

package name status build log
golang-oldstable-image ⛔ excluded live log
golang-stable-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2144 for aarch64: current state: published
Build results:

package name status build log
golang-oldstable-image ⛔ excluded live log
golang-stable-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2144 for x86_64: current state: published
Build results:

package name status build log
golang-oldstable-image ✅ succeeded live log
golang-stable-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-2144 for aarch64: current state: published
Build results:

package name status build log
golang-oldstable-image ✅ succeeded live log
golang-stable-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2144/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-2144/containerfile/opensuse/bci/golang:latest

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Created a staging project on OBS for 7: home:defolos:BCI:Staging:SLE-15-SP7:7-2144
Changes pushed to branch 7-2144 as commit ee2ea3229a68fc18c3a9fd4d9094ecbd32dd70ba
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2144 for x86_64: current state: published
Build results:

package name status build log
golang-oldstable-image ⛔ excluded live log
golang-oldstable-openssl-image ⛔ excluded live log
golang-stable-image ⛔ excluded live log
golang-stable-openssl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2144 for aarch64: current state: published
Build results:

package name status build log
golang-oldstable-image ⛔ excluded live log
golang-oldstable-openssl-image ⛔ excluded live log
golang-stable-image ⛔ excluded live log
golang-stable-openssl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2144 for s390x: current state: published
Build results:

package name status build log
golang-oldstable-image ⛔ excluded live log
golang-oldstable-openssl-image ⛔ excluded live log
golang-stable-image ⛔ excluded live log
golang-stable-openssl-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP7:7-2144 for ppc64le: current state: published
Build results:

package name status build log
golang-oldstable-image ⛔ excluded live log
golang-oldstable-openssl-image ⛔ excluded live log
golang-stable-image ⛔ excluded live log
golang-stable-openssl-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2144 for x86_64: current state: published
Build results:

package name status build log
golang-oldstable-image ✅ succeeded live log
golang-oldstable-openssl-image ✅ succeeded live log
golang-stable-image ✅ succeeded live log
golang-stable-openssl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2144 for aarch64: current state: published
Build results:

package name status build log
golang-oldstable-image ✅ succeeded live log
golang-oldstable-openssl-image ✅ succeeded live log
golang-stable-image ✅ succeeded live log
golang-stable-openssl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2144 for s390x: current state: published
Build results:

package name status build log
golang-oldstable-image ✅ succeeded live log
golang-oldstable-openssl-image ✅ succeeded live log
golang-stable-image ✅ succeeded live log
golang-stable-openssl-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP7:7-2144 for ppc64le: current state: published
Build results:

package name status build log
golang-oldstable-image ✅ succeeded live log
golang-oldstable-openssl-image ✅ succeeded live log
golang-stable-image ✅ succeeded live log
golang-stable-openssl-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.7 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2144/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp7/7-2144/containerfile/bci/golang:1.22

@dirkmueller dirkmueller merged commit 3107b7f into main Dec 20, 2024
9 checks passed
@dirkmueller dirkmueller deleted the golang-limit-version-to-three-digits branch December 20, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmueller dirkmueller dirkmueller approved these changes

@alexandrevicenzi alexandrevicenzi Awaiting requested review from alexandrevicenzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcermak @dirkmueller