Unify exceptions handling during VPC deletion #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorodskyi
changed the title
asmorodskyi
force-pushed
the
fix_vpc12
branch
2 times, most recently
from
f192c69 to
a2026a1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 78.78% 78.81% +0.04%
==========================================
Files 22 22
Lines 1649 1647 -2
==========================================
- Hits 1299 1298 -1
+ Misses 350 349 -1 ☔ View full report in Codecov by Sentry. |
There was two different attempts to handle known exceptions in VPC deletion. It appears that having both of them cause collisions. So I unify them into one.
ricardobranco777
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was two different attempts to handle known exceptions in VPC deletion. It appears that having both of them cause collisions. So I unify them into one.